Gnash - The GNU Flash player - Patches: patch #8721, Patch to make `GetVariable()`...
You are not allowed to post comments on this tracker with your current authentication level.
patch #8721: Patch to make `GetVariable()` return String regardless of original variable type
Submitter: | Nutchanon Wetchasit <nachanon> | ||
Submitted: | Fri 21 Aug 2015 03:20:38 PM UTC | ||
Category: | core | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | strk | Open/Closed: | Closed |
Jump to the original submission
Mon 25 Jan 2016 04:34:50 PM UTC, comment #16: |
Sandro Santilli <strk> |
Mon 25 Jan 2016 03:13:32 PM UTC, comment #15: For the automated test case of this fix, see patch #8835 (committed as 48e75c1). |
Nutchanon Wetchasit <nachanon> |
Mon 07 Dec 2015 05:34:04 PM UTC, comment #14: Oops, sorry for the noise, my last two comments (#12 and #13) were indeed intended to go to bug #46607 -- thanks Nutchanon for copying them over |
Sandro Santilli <strk> |
Mon 07 Dec 2015 04:08:59 PM UTC, comment #13: Also, _pos is never updated because there's a single buffer whose size() is < _in_point |
Sandro Santilli <strk> |
Mon 07 Dec 2015 04:05:58 PM UTC, comment #12: Bastiaan the consumeInPoint method in your change looks suspicious as you're setting _pos only at the final iteration of the loop, setting it to the advancement within the last buffer, rather than advancing all the buffers. |
Sandro Santilli <strk> |
Mon 07 Dec 2015 03:56:50 PM UTC, comment #11: I think we had a gnashrc setting for "ignorefscommand" which defaults to true when runnign as plugin but can be false while runinng the testsuite |
Sandro Santilli <strk> |
Mon 07 Dec 2015 03:45:06 PM UTC, comment #10: An alternative way for testing this would be adding a separate test runner
|
Nutchanon Wetchasit <nachanon> |
Mon 07 Dec 2015 03:42:08 PM UTC, comment #9: @strk:
|
Nutchanon Wetchasit <nachanon> |
Thu 03 Dec 2015 11:34:00 AM UTC, comment #8: Nutchanon:
|
Sandro Santilli <strk> |
Fri 28 Aug 2015 06:58:38 PM UTC, comment #7: The patch was committed as dc51f5389e4726486b631864151dcfe28e556cf6 |
Sandro Santilli <strk> |
Fri 28 Aug 2015 06:49:31 PM UTC, comment #6: I'd still love to see a testcase associated with this change, do you think you can provide that ? |
Sandro Santilli <strk> |
Fri 28 Aug 2015 01:16:04 PM UTC, comment #5: For the behavior difference between Gnash and Flash, I have tested around
|
Nutchanon Wetchasit <nachanon> |
Fri 28 Aug 2015 12:50:57 PM UTC, comment #4: See the attached `0001_return-string-from-getvariable-v2.patch`
|
Nutchanon Wetchasit <nachanon> |
Tue 25 Aug 2015 05:23:40 PM UTC, comment #3: See also plugin/npapi/test.cpp for a possible place to write tests for this patch. |
Sandro Santilli <strk> |
Mon 24 Aug 2015 10:49:57 AM UTC, comment #2: The bool as_object::get_member method is documented to return false when the variable isn't found (rather than is set as undefined), and your patch seems to use that distinction. Are you saing as_object::get_member doesn't do what it documents as doing ? |
Sandro Santilli <strk> |
Mon 24 Aug 2015 10:39:32 AM UTC, comment #1: It'd be a good idea to include the knowledge about special case and whtt the correct handling would be (for undefined vs. null) in a code comment. Also, a testcase for the whole ExternalInterface would still be great to have for all these fixes. |
Sandro Santilli <strk> |
Fri 21 Aug 2015 03:20:38 PM UTC, original submission:
See the attached `0001_return-string-from-getvariable.patch`.
|
Nutchanon Wetchasit <nachanon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-01-25 | strk | Status | Ready For Test | Done | |
Open/Closed | Open | Closed | |||
2015-08-28 | strk | Status | In Progress | Ready For Test | |
2015-08-28 | nachanon | Attached File | - | Added 0001_return-string-from-getvariable-v2.patch, #34761 | |
2015-08-28 | nachanon | Attached File | - | Added 0001_return-string-from-getvariable-v2.patch, #34759 | |
2015-08-24 | strk | Status | None | In Progress | |
Assigned to | None | strk | |||
2015-08-21 | nachanon | Attached File | - | Added 0001_return-string-from-getvariable.patch, #34689 |
Powered by Savane 3.13-758e.
Corresponding source code
So I'm closing this. Thanks.