Gnash - The GNU Flash player - Patches: patch #8720, Patch for fixing GC-related issue...
You are not allowed to post comments on this tracker with your current authentication level.
patch #8720: Patch for fixing GC-related issue in ExternalInterface registration
Submitter: | Nutchanon Wetchasit <nachanon> | ||
Submitted: | Wed 19 Aug 2015 09:39:39 AM UTC | ||
Category: | core | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | strk | Open/Closed: | Closed |
Tue 08 Sep 2015 07:58:07 PM UTC, comment #2: |
Bastiaan Jacques <bjacques> |
Wed 19 Aug 2015 10:32:14 AM UTC, comment #1: Thanks for working on tests ! :)
|
Sandro Santilli <strk> |
Wed 19 Aug 2015 09:39:39 AM UTC, original submission:
This is a follow-up to patch #8715 (ExternalInterface callback fix).
|
Nutchanon Wetchasit <nachanon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2015-08-19 | strk | Status | None | Done | |
Assigned to | None | strk | |||
Open/Closed | Open | Closed | |||
2015-08-19 | nachanon | Attached File | - | Added 0003_add-externalinterface-gc-provision.patch, #34677 |
Powered by Savane 3.13-758e.
Corresponding source code
+ for (std::map<std::string, as_object*>::const_iterator method_iterator
+ = _externalCallbackMethods.begin();
+ method_iterator != _externalCallbackMethods.end();
+ method_iterator++)
I have a minor quibble with this, and that is that due to the vagaries of C++, method_iterator++ is actually slower than ++method_iterator.
At any rate, in c2f388e26873b I simply converted these loops to C++11 syntax, which avoids this issue and is also a lot less typing.