patchGNU Autoconf Archive - Patches: patch #8701, AX_PYTHON_DEVEL should provide...

 
 

patch #8701: AX_PYTHON_DEVEL should provide PYTHON_LIBS, not PYTHON_LDFLAGS

Submitter:  None
Submitted:  Fri 10 Jul 2015 07:30:10 PM UTC
   
 
Priority:  5 - Normal Status:  Done
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 20 Oct 2015 08:48:39 AM UTC, comment #5: 

Thanks for pushing that to git. Here is the patch to update AX_BOOST_PYTHON to match this: https://savannah.gnu.org/patch/index.php?8776

Murray Cumming <murrayc>
Fri 25 Sep 2015 10:50:49 AM UTC, comment #4: 

Pushed in 35f52877a6c1c8568575c2456fb1004e92839a82.

Peter Simons <simons>
Group administrator
Mon 14 Sep 2015 09:19:52 PM UTC, comment #3: 


> Personally, I'm reluctant to break a well established interface purely for aesthetic reasons


The change is absolutely not for aesthetic reasons. It is for reasons of correctness. It leads to broken builds with newer, stricter, versions of gcc, particularly when using AX_BOOST_PYTHON(), though this is not the only macro that needs fixing.

Murray Cumming <murrayc>
Wed 26 Aug 2015 10:01:33 AM UTC, comment #2: 

Adding previous contributors to this macro to Cc to solicit their opinion.

Personally, I'm reluctant to break a well established interface purely for aesthetic reasons, but others may feel differently about this.

Peter Simons <simons>
Group administrator
Fri 10 Jul 2015 07:34:30 PM UTC, comment #1: 

Also, this would be consistent with similar macros such as PKG_CHECK_MODULES(), which provides WHATEVER_CFLAGS and WHATEVER_LIBS.

murrayc

Anonymous
Fri 10 Jul 2015 07:30:10 PM UTC, original submission:  

As I understand it, LDFLAGS is for linker flags and LIBS is for libraries. so the -L and -l options should be in a LIBS variable rather than an LDFLAGS variable.

This has not been a problem until recently. But some more recent versions of gcc (or maybe just g++, or maybe the linker) have started ignoring -L and -l command line options that appear after the source filename. But that's where AC_LINK_IFELSE() puts LDFLAGS, as it presumably should. And that makes other checks such as AX_BOOST_PYTHON fail.

This is an attempt at a patch to correct this in AX_PYTHON_DEVEL, though I'm not sure if there are really some PYTHON_EXTRA_LDFLAGS (not libs) that should still be discovered.

I have similar updates for AX_BOOST_BASE and AX_BOOST_PYTHON but I thought I'd start the conversation here first. Maybe other macros would need to be updated, and obviously application build files would need to be updated (when they update their copy of AX_PYTHON_DEVEL), but I think it would be worth it to remove this confusion.


This is how I discovered this:
http://stackoverflow.com/questions/31304553/linker-error-with-libboost-python-py34-on-ubuntu-15-04/31330681#31330681

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by murrayc (Posted a comment)
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by simons
  • -email is unavailable- added by simons
  • -email is unavailable- added by simons
  • -email is unavailable- added by simons
  • -email is unavailable- added by simons
  • -email is unavailable- added by None (Submitted the item)
  •  

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-09-25 simons StatusNeed Info Done
        Open/ClosedOpen Closed
    2015-08-26 simons StatusNone Need Info
        Carbon-Copy- Added daniel mullner <muellner@math.stanford.edu>
        Carbon-Copy- Added horst knorr <hk_classes@knoda.org>
        Carbon-Copy- Added matteo settenvini <matteo@member.fsf.org>
        Carbon-Copy- Added rafael laboissiere <rafael@laboissiere.net>
        Carbon-Copy- Added sebastian huber <sebastian-huber@web.de>
    2015-07-10 None Attached File- Added 0001-AX_PYTHON_DEVEL-provide-PYTHON_LIBS-not-PYTHON_LDFLA.patch, #34419

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code