patchGNU source-highlight - Patches: patch #8679, Add language definition for vim...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8679: Add language definition for vim config files

Submitter:  Atte Peltomaki <koston>
Submitted:  Mon 01 Jun 2015 12:35:36 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Sun 02 Jun 2019 03:16:04 PM UTC, comment #4: 

Thank you for the patch.
I'm checking it in despite its lack of a test case.
Normally I wouldn't do this but I think it's probably
better to have it than not.

Tom Tromey <tromey>
Group administrator
Wed 03 Jun 2015 11:10:22 AM UTC, comment #3: 

p.s. I'd like to take this opportunity to express my disappointment at Vim devs for choosing '"' as comment delimiter. It's difficult to parse to begin with, and downright impossible to parse correctly without hard-coding some special cases.

I'm pretty sure this syntax file is still a far cry from perfect (Vim's own syntax file for itself is a seriously complex monolith and still fails at some things), but it's better than anything else I've found.

Atte Peltomaki <koston>
Wed 03 Jun 2015 11:05:31 AM UTC, comment #2: 

I tested the file using default vimrc_example.vim from Vim upstream repository and subsequently fixed the vim.lang to process it correctly.

I didn't quite understand how tests are added to the suite so I didn't include it in the patch, but here's the file highlighted, using sh_vim.css stylesheet (wrapped w/ AsciiDoc):

http://ass.kameli.org/vimrc_example.html

Let me know if you need something more.

Atte Peltomaki <koston>
Tue 02 Jun 2015 11:51:13 AM UTC, comment #1: 

Thanks for the patch!  An input file to add to the test suite would be helpful.

Lorenzo Bettini <bettini>
Group administrator
Mon 01 Jun 2015 12:35:36 PM UTC, original submission:  

Original source of vim.lang:
https://github.com/dahu/SohiVila/blob/master/vim.lang

Submitted with permission from author.

Atte Peltomaki <koston>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #34152:  0001-Add-language-definition-for-vim-config-files.patch added by koston (31KiB - text/x-patch - Updated comment detection.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by tromey (Posted a comment)
  • -email is unavailable- added by bettini (Posted a comment)
  • -email is unavailable- added by koston (Submitted the item)
  • -email is unavailable- added by koston (Original author)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-06-02 tromey Open/ClosedOpen Closed
    2015-06-03 koston Attached File- Added 0001-Add-language-definition-for-vim-config-files.patch, #34152
    2015-06-01 koston Attached File- Added 0001-Add-language-definition-for-vim-config-files.patch, #34139
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code