patchGNU Autoconf Archive - Patches: patch #8672, [patch] ax_berkeley_db_cxx.m4 -...

 
 

patch #8672: [patch] ax_berkeley_db_cxx.m4 - add support for freebsd installations

Submitter:  T.v.Dein <tlinden>
Submitted:  Fri 15 May 2015 01:13:58 PM UTC
   
 
Priority:  5 - Normal Status:  Done
Assigned to:  simons Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 23 May 2015 10:14:27 AM UTC, comment #2: 

I pushed your commit in https://github.com/peti/autoconf-archive/commit/b87ebf8630e85447adc29fe26ab2e4a2d82877f9 and added the previous contributors of this macro to Cc to give them a chance to review the change.

Thank you very much for your contribution!

Peter Simons <simons>
Group administrator
Sat 16 May 2015 07:56:59 AM UTC, comment #1: 

Hello,

the patched version had still a bug and didn't find bdb 4.2 on freebsd. Now - hopefully - every variant should be covered.

Also I fixed the bug mentioned with cut -d. -f2. The parameter -s was missing, and the variable substiturion on the lines following didn't work.

I attached a new patch.


best,
Tom

(file #34024)

T.v.Dein <tlinden>
Fri 15 May 2015 01:13:58 PM UTC, original submission:  

The current state of ax_berkeley_db_cxx.m4 does not find berkeley db on a freebsd system. Here's how a bdb install looks on my system:

/usr/local/lib/libdb41_cxx.so
/usr/local/include/db41/db_cxx.h

The macro didn't find it, because it only looked for:

/usr/local/lib/libdb_cxx-4.1.so

So, the supplied patch adds support for this. There's a flipside though, it's slower now since it checks more combinations.

Besides, there's also a bug left in the macro: if you specify a minimum version number consisting of just one digit, it fails, because:

echo 4 | cut -d. -f2
4

echo 4 | cut -d. -f3
4

I'm not sure why. However, because of this it looks for 4.4.4, which is not what I want if I specify "4". So, it should at least be noted in the documentation that one has to specify a full version number such as 4.0.0 (in which case it works as expected)


best,
Tom

T.v.Dein <tlinden>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by simons
  • -email is unavailable- added by simons
  • -email is unavailable- added by simons
  • -email is unavailable- added by tlinden (Submitted the item)
  •  

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-08-26 simons Open/ClosedOpen Closed
    2015-08-26 simons StatusReady For Test Done
    2015-05-23 simons StatusNone Ready For Test
        Assigned toNone simons
        Carbon-Copy- Added vaclav slavik <vaclav.slavik@matfyz.cz>
        Carbon-Copy- Added stephan suerken <absurd@debian.org>
        Carbon-Copy- Added kirill a. korinskiy <catap@catap.ru>
    2015-05-16 tlinden Attached File- Added ax_berkeley_db_cxx-oldbsdinstall-fix-20150516.patch, #34024
    2015-05-15 tlinden Attached File- Added ax_berkeley_db_cxx-oldbsdinstall-fix-20150515.patch, #34017

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code