patchGNU Autoconf Archive - Patches: patch #8638, Remove non-ASCII Characters-in...

 
 

patch #8638: Remove non-ASCII Characters-in Comments

Submitter:  Moritz Klammler <moritz_klammler>
Submitted:  Sat 04 Apr 2015 02:29:58 AM UTC
   
 
Priority:  5 - Normal Status:  Done
Assigned to:  simons Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 21 Apr 2015 07:45:58 PM UTC, comment #1: 

Thank you very much for catching this! I applied your patch, and I also switched the continuous builds at https://travis-ci.org/peti/autoconf-archive and http://hydra.cryp.to/jobset/autoconf-archive/master to python3 to ensure that such an issue is detected immediately in the future.

Peter Simons <simons>
Group administrator
Sat 04 Apr 2015 02:29:58 AM UTC, original submission:  

The files `m4/ax_compiler_flags.m4`, `m4/ax_compiler_flags_cflags.m4`, `m4/ax_compiler_flags_cxxflags.m4` and `m4/ax_compiler_flags_ldflags.m4` contained non-ASCII characters that caused (at least if using Python 3) the `macro2m4.py` script that is run as part of `make maintainer-all` to fail.

Since all offensive characters were apostrophes in comments, I simply replaced them with ASCII 39 characters.  This fixes the immediate issue.  I assume that ASCII encoding was deliberately chosen for maximum portability.  Otherwise, it might be preferred to modify the Python script to use UTF-8 encoding thus allowing such characters.

I have also attached a little Python script that can be used to check whether a file contains non-ASCII characters.  I've run it over all `m4/*.m4` files and it did not report any other issues.

Moritz Klammler <moritz_klammler>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by moritz_klammler (Submitted the item)
  •  

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-04-21 simons StatusNone Done
        Assigned toNone simons
        Open/ClosedOpen Closed
    2015-04-04 moritz_klammler Attached File- Added 0001-Removed-non-ASCII-characters-in-comments.patch, #33525
        Attached File- Added bad-characters.py, #33526

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code