patchGNU Octave - Patches: patch #8623, cross mkoctfile

 
 

patch #8623: cross mkoctfile

Submitter:  John Donoghue <lostbard>
Submitted:  Wed 18 Mar 2015 08:50:54 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 02 Apr 2015 01:50:43 AM UTC, comment #16: 

Closing as done with ability to create cross built mkoctfile and octave-config tools pushed to mercurial.

John Donoghue <lostbard>
Group Member
Wed 25 Mar 2015 04:28:39 PM UTC, comment #15: 

Patch to add EXEEXT and SHLEXT to octave-config.


(file #33451)

John Donoghue <lostbard>
Group Member
Fri 20 Mar 2015 12:47:14 PM UTC, comment #14: 

Pushed http://hg.savannah.gnu.org/hgweb/octave/rev/28a9e59d0714

Option to enable cross build tools is now --enable-cross-tools, which will then build a cross mkoctfile and octave-config

John Donoghue <lostbard>
Group Member
Fri 20 Mar 2015 02:24:45 AM UTC, comment #13: 

Yeah, there are some OF packages that use octave-config, there are even some that use octave itself during the build. For example, I just made some changes to the communications package to use octave --eval during the build.

If we add more variables to mkoctfile and/or octave-config, I wouldn't need octave --eval. Should I file a wishlist bug about that (not a release blocker)?

Mike Miller <mtmiller>
Group Member
Thu 19 Mar 2015 11:23:25 PM UTC, comment #12: 

Pushed for mxe http://hg.octave.org/mxe-octave/rev/58935b4de51f.
--enable-binary-packages in configure will make mxe-octave compile the .oct files in packages.

John Donoghue <lostbard>
Group Member
Thu 19 Mar 2015 07:39:20 PM UTC, comment #11: 

of course they do :)

And a few would perhaps benefit from using it, if they don't use configure scripts.

John Donoghue <lostbard>
Group Member
Thu 19 Mar 2015 07:28:07 PM UTC, comment #10: 

Maybe, yes.  Do any of the Octave Forge Makefiles use octave-config?

John W. Eaton <jwe>
Group administrator
Thu 19 Mar 2015 07:18:02 PM UTC, comment #9: 

Would it make sense to also create a cross octave-config?

John Donoghue <lostbard>
Group Member
Thu 19 Mar 2015 06:11:10 PM UTC, comment #8: 

Updated mxe patch

I believe around 16 either don't have to compile or compile ok in mxe cross compile.

12 currently fail - these now have build rules of OCTAVE_FORGE_PKG_BUILD_NOCOMPILE so that they will package without attempting to compile.

Of the failing ones, some of these fail native build anyway, a few looks to have makefiles or configure scripts that are not cross build friendly and so need updates.

John Donoghue <lostbard>
Group Member
Wed 18 Mar 2015 11:24:13 PM UTC, comment #7: 
John Donoghue <lostbard>
Group Member
Wed 18 Mar 2015 10:26:25 PM UTC, comment #6: 

Currently, that what I did - the mxe-octave patch installing to BUILD_TOOLS_PREFIX/bin

The tool itself is named as the (host_triplet)-mkoctfile.

Is the ultimate goal to not only compile the packages but install them where they need to be installed within mxe?

John Donoghue <lostbard>
Group Member
Wed 18 Mar 2015 09:17:34 PM UTC, comment #5: 

For mxe-octave, I think it belongs in $(ROOT_PREFIX)/bin.

Although we need it for building packages, it doesn't really make sense for it to be installed in the $(HOST_PREFIX)/bin directory.  So maybe the installation is outside the scope of the Octave build system?

John W. Eaton <jwe>
Group administrator
Wed 18 Mar 2015 09:06:54 PM UTC, comment #4: 

One other thing - currently, even when enabled it, it doesn't 'install' the cross tool - just builds it.

I wasn't sure really what the best thing to do in terms of the installing rule/destination would/should be.

John Donoghue <lostbard>
Group Member
Wed 18 Mar 2015 09:04:23 PM UTC, comment #3: 

ok - I will play around with it a little more tonight and then commit the octave hg stuff - I have compiled with/without it enabled.

For the mxe side, we should probably provide a similar configure option to enable it (default off) so it doesn't effect anything for normal mxe builds.

John Donoghue <lostbard>
Group Member
Wed 18 Mar 2015 08:57:20 PM UTC, comment #2: 

Nice.  I'll take a look at this, but my initial reaction is to go ahead and commit it and work out any issues later.  Especially since it's optional, I don't see it causing trouble.  Thanks for working on this.

John W. Eaton <jwe>
Group administrator
Wed 18 Mar 2015 08:51:48 PM UTC, comment #1: 

The second patch adds changes to mxe-octave to allow compile of the of-general package.
It only compiles the oct files - doesn't install them, however it makes installing the package from within windows relatively quick as doesn't need to compile anything.

(file #33394)

John Donoghue <lostbard>
Group Member
Wed 18 Mar 2015 08:50:54 PM UTC, original submission:  

Heres a patch  to create a cross mkoctfile within octave (if cross built, and if --enable-cross-mkoctfile is specified via configure.

Its a little rough, only tested to work on my fedora box, but perhaps can work as a starting point. Currently it relies on the fact that that the build host has the few gnulib functions used by mkoctfile as native functions.



John Donoghue <lostbard>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #33451:  config_additions.patch added by lostbard (4KiB - application/octet-stream)
file #33394:  mxeqt2.patch added by lostbard (1KiB - application/octet-stream)
file #33393:  crossmkoctfile2.patch added by lostbard (13KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by lostbard
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-04-02 lostbard StatusNone Done
        Open/ClosedOpen Closed
    2015-03-25 lostbard Attached File- Added config_additions.patch, #33451
    2015-03-18 lostbard Carbon-Copy- Added jwe
    2015-03-18 lostbard Attached File- Added mxeqt2.patch, #33394
    2015-03-18 lostbard Attached File- Added crossmkoctfile2.patch, #33393

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code