patchGNU Octave - Patches: patch #8372, Added New Functions in Mapping

 
 

patch #8372: Added New Functions in Mapping

Submitted by:  None
Submitted on:  Tue 04 Mar 2014 09:29:25 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: In ProgressPrivacy: Public
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 27 Mar 2015 08:45:54 PM UTC, comment #5:

Oopsie Pooja,

Wrong bug report, I meant omment #4 for patch #8377.
Apologies for the confusion.

Your contributions are next on my review list ...

Philip Nienhuis <philipnienhuis>
Project Member
Fri 27 Mar 2015 08:41:05 PM UTC, comment #4:

Hi Felipe and Sandeep:

I've further converted your functions to Octave coding style, see attached patch.

Some remarks:

  • Where are the functions myassert.m and convert_to_cartesian.m ?
  • Please review licenses for get_J2.m (lacking altogether), get_ellipsoid.m, get_sinefun.m and geodetic2ned.m

Would you agree with GPL-3?

  • Furthermore there's one (the last) test in get_ellipsoid.m that seems to run only in Matlab?

I hope to be able to include these functions in the next mapping package release (within -say- 3 weeks or so).
Could you please review my attach patch fix the above issues and supply a new patch on top of mine before mid-April, please?

Thanks

(file #33470)

Philip Nienhuis <philipnienhuis>
Project Member
Tue 24 Mar 2015 10:10:47 PM UTC, comment #3:

I'm having a look at them, together with some patches from patch #8377
May take some time (it's already over a year old, I know)

Philip Nienhuis <philipnienhuis>
Project Member
Wed 05 Mar 2014 06:34:51 AM UTC, comment #2:

I have added some comments in the scripts(submitted as patch #8371 and #8372) for better readability.

Thanks,
Pooja Rao

Anonymous
Tue 04 Mar 2014 08:50:02 PM UTC, comment #1:

These new function files also contain some simple tests. Thanks!

-Pooja

Anonymous
Tue 04 Mar 2014 09:29:25 AM UTC, original submission:

Added functions rad2km, sm2rad, sm2deg, nm2rad, nm2deg in the mapping package. Updated the INDEX and NEWS files too. I forgot to add the file for tracking and hence the two .diff files.

Thanks,
Pooja Rao

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #33470:  mapping_pkg_PRN.patch added by philipnienhuis (79kB - application/x-download)
file #30919:  fun_km2rad.diff added by None (3kB - text/x-diff - Moved km2rad from patch #8371 to #8372 )
file #30889:  test_format_chngd.diff added by None (4kB - text/x-diff - Chnaged test format so tests could be run interactively without problems)
file #30800:  docstr_added.diff added by None (4kB - text/x-diff - Hi, I added a little more descriptive docstrings as suggested by Juan Pablo Carbajal. -Pooja)
file #30777:  comments_added.diff added by None (5kB - text/x-diff - I have added some comments to the the functions that I implemented in patch #8371 and #8372)
file #30766:  mapping_new_funcs.diff added by None (11kB - text/x-diff)
file #30767:  INDEX_NEWS_updated.diff added by None (906B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 27 Mar 2015 08:45:54 PM UTCphilipnienhuisStatusNeed Info=>In Progress
    Fri 27 Mar 2015 08:41:05 PM UTCphilipnienhuisAttached File-=>Added mapping_pkg_PRN.patch, #33470
      StatusIn Progress=>Need Info
    Tue 24 Mar 2015 10:10:47 PM UTCphilipnienhuisStatusNone=>In Progress
    Sun 16 Mar 2014 07:46:07 PM UTCNoneAttached File-=>Added fun_km2rad.diff, #30919
    Fri 14 Mar 2014 12:36:40 AM UTCNoneAttached File-=>Added test_format_chngd.diff, #30889
    Thu 06 Mar 2014 02:29:15 PM UTCNoneAttached File-=>Added docstr_added.diff, #30800
    Wed 05 Mar 2014 06:32:33 AM UTCNoneAttached File-=>Added comments_added.diff, #30777
    Tue 04 Mar 2014 09:29:25 AM UTCNoneAttached File-=>Added mapping_new_funcs.diff, #30766
      Attached File-=>Added INDEX_NEWS_updated.diff, #30767

    Back to the top


    Powered by Savane 3.1-cleanup