patchGNU Octave - Patches: patch #8372, Added New Functions in Mapping

 
 

patch #8372: Added New Functions in Mapping

Submitted by:  None
Submitted on:  Tue Mar 4 09:29:25 2014  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Philip Nienhuis <philipnienhuis>Originator Email: -unavailable-
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri Apr 3 21:13:08 2015, comment #6:

Hi Pooja,

Took a little time but I have pushed your contributions. See:
http://hg.code.sf.net/p/octave/mapping

Apart from a little editing of NEWS hunk (due to intermediate contributions by me the NEWS file was changed too much) all your changesets applied flawlessly.
Kudos for neatly following Octave coding style.
Thanks!

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Fri Mar 27 20:45:54 2015, comment #5:

Oopsie Pooja,

Wrong bug report, I meant omment #4 for patch #8377.
Apologies for the confusion.

Your contributions are next on my review list ...

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Fri Mar 27 20:41:05 2015, comment #4:

Hi Felipe and Sandeep:

I've further converted your functions to Octave coding style, see attached patch.

Some remarks:

  • Where are the functions myassert.m and convert_to_cartesian.m ?
  • Please review licenses for get_J2.m (lacking altogether), get_ellipsoid.m, get_sinefun.m and geodetic2ned.m

Would you agree with GPL-3?

  • Furthermore there's one (the last) test in get_ellipsoid.m that seems to run only in Matlab?

I hope to be able to include these functions in the next mapping package release (within -say- 3 weeks or so).
Could you please review my attach patch fix the above issues and supply a new patch on top of mine before mid-April, please?

Thanks

(file #33470)

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Tue Mar 24 22:10:47 2015, comment #3:

I'm having a look at them, together with some patches from patch #8377
May take some time (it's already over a year old, I know)

Philip Nienhuis <philipnienhuis>
Project MemberIn charge of this item.
Wed Mar 5 06:34:51 2014, comment #2:

I have added some comments in the scripts(submitted as patch #8371 and #8372) for better readability.

Thanks,
Pooja Rao

Anonymous
Tue Mar 4 20:50:02 2014, comment #1:

These new function files also contain some simple tests. Thanks!

-Pooja

Anonymous
Tue Mar 4 09:29:25 2014, original submission:

Added functions rad2km, sm2rad, sm2deg, nm2rad, nm2deg in the mapping package. Updated the INDEX and NEWS files too. I forgot to add the file for tracking and hence the two .diff files.

Thanks,
Pooja Rao

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #33470:  mapping_pkg_PRN.patch added by philipnienhuis (79kB - application/x-download)
file #30919:  fun_km2rad.diff added by None (3kB - text/x-diff - Moved km2rad from patch #8371 to #8372 )
file #30889:  test_format_chngd.diff added by None (4kB - text/x-diff - Chnaged test format so tests could be run interactively without problems)
file #30800:  docstr_added.diff added by None (4kB - text/x-diff - Hi, I added a little more descriptive docstrings as suggested by Juan Pablo Carbajal. -Pooja)
file #30777:  comments_added.diff added by None (5kB - text/x-diff - I have added some comments to the the functions that I implemented in patch #8371 and #8372)
file #30766:  mapping_new_funcs.diff added by None (11kB - text/x-diff)
file #30767:  INDEX_NEWS_updated.diff added by None (906B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri Apr 3 21:13:08 2015philipnienhuisStatusIn Progress=>Done
      Assigned toNone=>philipnienhuis
      Open/ClosedOpen=>Closed
    Fri Mar 27 20:45:54 2015philipnienhuisStatusNeed Info=>In Progress
    Fri Mar 27 20:41:05 2015philipnienhuisAttached File-=>Added mapping_pkg_PRN.patch, #33470
      StatusIn Progress=>Need Info
    Tue Mar 24 22:10:47 2015philipnienhuisStatusNone=>In Progress
    Sun Mar 16 19:46:07 2014NoneAttached File-=>Added fun_km2rad.diff, #30919
    Fri Mar 14 00:36:40 2014NoneAttached File-=>Added test_format_chngd.diff, #30889
    Thu Mar 6 14:29:15 2014NoneAttached File-=>Added docstr_added.diff, #30800
    Wed Mar 5 06:32:33 2014NoneAttached File-=>Added comments_added.diff, #30777
    Tue Mar 4 09:29:25 2014NoneAttached File-=>Added mapping_new_funcs.diff, #30766
      Attached File-=>Added INDEX_NEWS_updated.diff, #30767

    Back to the top


    Powered by Savane 3.1-cleanup