patchGNU Octave - Patches: patch #8316, Variable Editor

 
 

patch #8316: Variable Editor

Submitted by:  Rüdiger Sonderfeld <ruediger>
Submitted on:  Thu 13 Feb 2014 08:53:55 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 15 Feb 2014 12:43:09 AM UTC, comment #3:

I've updated the patch. The variable editor is now refreshed every time `octave_link::set_workspace' gets called (i.e., every time it the octave interpreter waits for input). I'm open to better suggestions.

I fixed the thread safety issue and many other issues.

Remaining

  • Paste not working
  • Inserting/removing rows/cols (and Delete) not working (some untested code for it but no GUI interface)
  • No support for structure arrays
  • Plotting doesn't work for cell arrays.
  • "Variable from selection" always uses "unnamed" as variable name.
  • No window splitting
  • No data brush
  • No printing
  • No undo support
  • No sort
  • Some icons would be nice.

All in all it should be usable.

(file #30552)

Rüdiger Sonderfeld <ruediger>
Sat 15 Feb 2014 12:32:54 AM UTC, comment #2:

Mailinglist thread for this patch: https://mailman.cae.wisc.edu/pipermail/octave-maintainers/2014-February/039169.html

Rüdiger Sonderfeld <ruediger>
Sat 15 Feb 2014 12:32:23 AM UTC, comment #1:

Older patch https://savannah.gnu.org/patch/?8039
and discussion on the mailinglist: http://octave.1599824.n4.nabble.com/Experimental-matrix-editor-patch-td4652536.html

Rüdiger Sonderfeld <ruediger>
Thu 13 Feb 2014 08:53:55 PM UTC, original submission:

This patch adds a basic Variable Editor to the GUI. It is not finished but I wanted some input before continuing with it.

The biggest issue right now is that the editor does not detect changes happening to the variable inside Octave. It will continue displaying the old value. I don't know if there is a way in Octave to intercept changes to certain variables or how this could be implemented. The simplest way would be to update the display completely once `octave_link::set_workspace' gets called. But this would only update the view when Octave has finished and is waiting for new input. Maybe that would be good enough at least for an initial release.

There are some other issues

  • Paste not working
  • Inserting/removing rows/cols not working
  • No support for structure arrays (completely untested)
  • No subeditor opens for internal structures (but the input is eval'd so it is somewhat usable at the moment)
  • Plotting doesn't work for cell arrays.
  • Delete does not support shifting and always inserts 0 (should be [] for cell arrays)
  • No variable from selection or transpose feature
  • No window splitting
  • No data brush
  • No printing
  • No undo support
  • No sort
  • ...

And a potential thread safety issue. I call `symbol_table::varval' in `main_window' from the GUI thread to get the `octave_value'. It could be safely passed via signal but that would require registering `octave_value' as Qt metatype and I don't know what implications that would have (See http://qt-project.org/doc/qt-4.8/qmetatype.html#qRegisterMetaType).

Rüdiger Sonderfeld <ruediger>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30552:  variable-editor-2.patch added by ruediger (57kB - text/x-patch)
file #30545:  variable-editor.patch added by ruediger (45kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by ruediger (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 15 Feb 2014 12:43:09 AM UTCruedigerAttached File-=>Added variable-editor-2.patch, #30552
    Thu 13 Feb 2014 08:53:55 PM UTCruedigerAttached File-=>Added variable-editor.patch, #30545

    Back to the top


    Powered by Savane 3.1-cleanup