patchClasspath Extensions - Patches: patch #8296, gnu.inet.util.CRLFOutputStream add...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #8296: gnu.inet.util.CRLFOutputStream add writeAtBOL notification methods

Submitted by:  Conrad T. Pino <conradpino>
Submitted on:  Wed 29 Jan 2014 01:20:52 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: In ProgressPrivacy: Public
Assigned to: Conrad T. Pino <conradpino>Open/Closed: Open

Wed 29 Jan 2014 11:26:15 AM UTC, comment #5:

Upload patch file omitted from comment #4 update.

(file #30412)

Conrad T. Pino <conradpino>
Project MemberIn charge of this item.
Wed 29 Jan 2014 11:08:05 AM UTC, comment #4:

This patch update revises if statement layout and adds new constructor.

protected CRLFOutputStream(CRLFOutputStream out)
{
super(out);
atBOL = out.atBOL;
last = out.last;
}

The submitted patch file supersedes all prior versions.

Conrad T. Pino <conradpino>
Project MemberIn charge of this item.
Wed 29 Jan 2014 10:45:47 AM UTC, comment #3:

Excellent point; agreed.

Conrad T. Pino <conradpino>
Project MemberIn charge of this item.
Wed 29 Jan 2014 10:42:01 AM UTC, comment #2:

Please can you use curly braces to enclose all conditional statements, even if they are only 1 line.

Thus:
if (x) {
do_y();
}

not:
if (x)
do_y();

This improves code legibility and avoids a number of simple programmer errors that can occur.

Chris Burdess <dog>
Project Administrator
Wed 29 Jan 2014 10:34:49 AM UTC, comment #1:

Resolving https://savannah.gnu.org/bugs/?41383 issue requires an additional "public void ensureBOL() throws IOException" method.

Patch file #30403 is replaced by this submission.

(file #30409)

Conrad T. Pino <conradpino>
Project MemberIn charge of this item.
Wed 29 Jan 2014 01:20:52 AM UTC, original submission:

Add two (2) subclass notification methods to support resolving https://savannah.gnu.org/bugs/?40378#comment8 issue.

Conrad T. Pino <conradpino>
Project MemberIn charge of this item.

 

Attached Files
file #30412:  CRLFOutputStream.patch added by conradpino (3kB - application/octet-stream)
file #30409:  CRLFOutputStream.patch added by conradpino (3kB - application/octet-stream)
file #30403:  CRLFOutputStream.patch added by conradpino (2kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dog (Posted a comment)
  • -unavailable- added by conradpino (Submitted the item)
  • -unavailable- added by conradpino
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 29 Jan 2014 11:26:15 AM UTCconradpinoAttached File-=>Added CRLFOutputStream.patch, #30412
    Wed 29 Jan 2014 10:34:49 AM UTCconradpinoAttached File-=>Added CRLFOutputStream.patch, #30409
    Wed 29 Jan 2014 01:20:52 AM UTCconradpinoAttached File-=>Added CRLFOutputStream.patch, #30403
      Carbon-Copy-=>Added dog

    Back to the top


    Powered by Savane 3.1-cleanup