patchGNU Octave - Patches: patch #8265, [image package new functions]...

 
 

patch #8265: [image package new functions] imgradientxy.m imgradient.m

Submitter:  Brandon Miles <bmiles>
Submitted:  Sat 21 Dec 2013 06:45:10 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  carandraug Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 05 Jan 2014 08:37:32 AM UTC, comment #3: 

Thank you for the patch. I have added them to the image package with cset 75d6748324de which I signed with your name and email.

I then made some small changes to them in cset af3c7946534b. One of them being turning the %! comments you added into real test blocks so the functions can be tested with the command "test function_name".

I will make a new release of the image package soon which will include this two functions.

Carnë Draug <carandraug>
Group Member
Tue 31 Dec 2013 10:50:09 PM UTC, comment #2: 

I've uploaded new versions of the functions.  I've updated the documentation and added the tests.  Please let me know if you require any further changes.

Thanks,

Brandon

Brandon Miles <bmiles>
Wed 25 Dec 2013 03:31:01 AM UTC, comment #1: 

Thank you for contribution. I'm quite interested in this functions and would like to add them to the image package soon, before the new release.

I don't have time to take a look at closely at them yet, I'll do it later. But first of all, could you please add some tests to the functions? Take a look at the tests added at these for examples (tests are the %! at the bottom of the files) and let us know if you have any doubt




From quick glance, I only noticed that the help text for imgradientxy is wrong. Sound like it was written for imgradient though not copy and paste since you have something else there.

There's also some minor cosmetic issues required to follow the Octave coding guidelines which I'll gladly apply myself later.

Carnë Draug <carandraug>
Group Member
Sat 21 Dec 2013 06:45:10 PM UTC, original submission:  

New m-files imgradient and imgradientxy with documentation included.

This is my first submission, so please let me know if there are changes I need to make.

Brandon Miles <bmiles>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30139:  imgradientxy.m added by bmiles (4KiB - application/octet-stream - Here are the new files. I've included tests with these files and updated the documentation. Please let me know if any further changes are required.)
file #30140:  imgradient.m added by bmiles (4KiB - application/octet-stream - Here are the new files. I've included tests with these files and updated the documentation. Please let me know if any further changes are required.)
file #30057:  imgradient.m added by bmiles (3KiB - application/octet-stream)
file #30058:  imgradientxy.m added by bmiles (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bmiles (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-01-05 carandraug StatusIn Progress Done
        Open/ClosedOpen Closed
    2013-12-31 bmiles Attached File- Added imgradientxy.m, #30139
        Attached File- Added imgradient.m, #30140
    2013-12-25 carandraug StatusNone In Progress
        Assigned toNone carandraug
    2013-12-21 bmiles Attached File- Added imgradient.m, #30057
        Attached File- Added imgradientxy.m, #30058

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code