patchGNU Octave - Patches: patch #8250, OF gsl package: improve...

 
 

patch #8250: OF gsl package: improve performance of Si.m

Submitted by:  None
Submitted on:  Sun 01 Dec 2013 09:17:22 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOriginator Email: -unavailable-
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 02 Dec 2013 08:55:19 PM UTC, comment #1:

Are you sure this is really from the GSL package? I'll just paste here what I wrote on the original bug report:

I'm guessing this a replacement for the Si function in the specfun package and not gsl since it still bears the copyright for that file. It's actually bad that SI is implemented (most likely differently) in two different packages (but that will be fixed soon).

If this is a patch for the specfun package: the Si function has been deprecated and replaced by sinint. Could you please provide us with a patch against the development version of sinint

https://sourceforge.net/p/octave/specfun/ci/default/tree/inst/sinint.m

If this is a patch for the gsl package: the gsl package aims at being a wrapper for the GSL library. This a m file and not compatible with it, and therefore not acceptable.

Carnë Draug <carandraug>
Project Member
Sun 01 Dec 2013 09:17:22 PM UTC, original submission:

The Si Function is rather slow, and it produces spurious values.

> plot(Si(-100:0.1:100))
> plot(real(Si(-100:0.1:100)))


(shows complex components)

> plot(Si(0:0.3:400))


(what?)

The attached file improves Performance and is correct over all reals. It contains the old implementation to treat complex cases.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29752:  Si.m added by None (4kB - text/x-objcsrc)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 01 Dec 2013 09:17:22 PM UTCNoneAttached File-=>Added Si.m, #29752

    Back to the top


    Powered by Savane 3.1-cleanup