patchGNU Octave - Patches: patch #8250, OF gsl package: improve...

 
 

patch #8250: OF gsl package: improve performance of Si.m

Submitter:  None
Submitted:  Sun 01 Dec 2013 09:17:22 PM UTC
   
 
Category:  Forge : other Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 10 Apr 2018 06:20:00 AM UTC, comment #2: 

Closing old obsolete patch. The sinint function is part of Octave version 4.4.

Mike Miller <mtmiller>
Group Member
Mon 02 Dec 2013 08:55:19 PM UTC, comment #1: 

Are you sure this is really from the GSL package? I'll just paste here what I wrote on the original bug report:

I'm guessing this a replacement for the Si function in the specfun package and not gsl since it still bears the copyright for that file. It's actually bad that SI is implemented (most likely differently) in two different packages (but that will be fixed soon).

If this is a patch for the specfun package: the Si function has been deprecated and replaced by sinint. Could you please provide us with a patch against the development version of sinint

https://sourceforge.net/p/octave/specfun/ci/default/tree/inst/sinint.m

If this is a patch for the gsl package: the gsl package aims at being a wrapper for the GSL library. This a m file and not compatible with it, and therefore not acceptable.

Carnë Draug <carandraug>
Group Member
Sun 01 Dec 2013 09:17:22 PM UTC, original submission:  



The Si Function is rather slow, and it produces spurious values.

> plot(Si(-100:0.1:100))
> plot(real(Si(-100:0.1:100)))


(shows complex components)

> plot(Si(0:0.3:400))


(what?)

The attached file improves Performance and is correct over all reals. It contains the old implementation to treat complex cases.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29752:  Si.m added by None (4KiB - text/x-objcsrc)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-10 mtmiller CategoryNone Forge : other
        StatusNone Wont Do
        Open/ClosedOpen Closed
    2013-12-02 carandraug Dependencies- bugs #40770 is dependent
    2013-12-01 None Attached File- Added Si.m, #29752

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code