patchGNU Octave - Patches: patch #8239, Remove setting value unnecessarily...

 
 

patch #8239: Remove setting value unnecessarily to retval in main.in.cc

Submitter:  PrasannaKumar Muralidharan <prasannatsm>
Submitted:  Sat 16 Nov 2013 05:02:03 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 04 May 2014 01:55:20 PM UTC, comment #3: 

The mailing list is a good place to discuss these sorts of things.  Sometimes it can be pretty hard to determine what the best thing to do is.  In this case, I started to apply your patch and only then noticed that what the original coder had probably intended was for Octave to exit.

Rik <rik5>
Group administrator
Sun 04 May 2014 04:05:30 AM UTC, comment #2: 

I was not aware of how octave should behave when setsid() fails. It will be good if I could understand such things before submitting a patch / bug report.

What is the best way to discuss such details? Can this be discussed in mailing list?

PrasannaKumar Muralidharan <prasannatsm>
Sun 04 May 2014 12:11:04 AM UTC, comment #1: 

I took a slightly different approach.  It appears that Octave was really meant to abort if setsid() failed so the assignment to retval was accurate.  See this changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/f8203daed9d4).  Thanks for pointing this out.

Rik <rik5>
Group administrator
Sat 16 Nov 2013 05:02:03 AM UTC, original submission:  


PrasannaKumar Muralidharan <prasannatsm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by prasannatsm (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-05-04 rik5 StatusNone Done
        Open/ClosedOpen Closed
    2013-11-16 prasannatsm Attached File- Added remove_unnecessary_setting_value.diff, #29629

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code