patchGnash - The GNU Flash player - Patches: patch #8230, Patch for "Prefer prefix...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8230: Patch for "Prefer prefix ++/-- operators" (from cppcheck)

Submitter:  Julien Nabet <julien2412>
Submitted:  Fri 01 Nov 2013 07:32:43 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Thu 16 Jan 2014 11:33:46 AM UTC, comment #5: 

I've commited the patch.

Petter Reinholdtsen <pere>
Group Member
Thu 16 Jan 2014 11:10:13 AM UTC, comment #4: 

I actually hadn't read the patch, just the original submission, which made me think tree.hh was touched. Now I red the patch and it seems good to me. Feel free to commit, thanks !

Sandro Santilli <strk>
Group Member
Thu 16 Jan 2014 10:49:28 AM UTC, comment #3: 

The diffstat of the patch do not touch tree.hh, so I fail to see how the fact that it originates elsewhere should be relevant.  Care to elaborate?

 cygnal/libamf/amf.cpp                   |    8 ++++----
 cygnal/libamf/amf_msg.cpp               |    4 ++--
 cygnal/libamf/element.cpp               |    6 +++---
 cygnal/libamf/flv.cpp                   |    4 ++--
 cygnal/libamf/lcshm.cpp                 |    8 ++++----
 cygnal/libamf/sol.cpp                   |   10 +++++-----
 cygnal/libnet/cache.cpp                 |    8 ++++----
 cygnal/libnet/cque.cpp                  |    6 +++---
 cygnal/libnet/network.cpp               |    2 +-
 cygnal/libnet/rtmp.cpp                  |    2 +-
 cygnal/libnet/rtmp_msg.cpp              |    8 ++++----
 cygnal/libnet/statistics.cpp            |    2 +-
 cygnal/rtmp_server.cpp                  |    2 +-
 cygnal/testsuite/libamf.all/test_lc.cpp |    6 +++---
 extensions/gtk2/gtkext.cpp              |    2 +-
 librender/opengl/Renderer_ogl.cpp       |    2 +-
 plugin/aos4/plugin.cpp                  |    2 +-
 plugin/win32/plugin.cpp                 |    2 +-
 18 files changed, 42 insertions(+), 42 deletions(-)

Petter Reinholdtsen <pere>
Group Member
Wed 15 Jan 2014 11:23:57 AM UTC, comment #2: 

The only reason would be that tree.hh is not ours. Check headers, best reported upstream and upgraded once fixed, or any patch of ours would be replaced on upgrade.

Sandro Santilli <strk>
Group Member
Wed 15 Jan 2014 11:14:48 AM UTC, comment #1: 

The change make sense to me.  Any reason not to apply it?  It applies fairly cleanly to the git HEAD (with one fuzzy).

Petter Reinholdtsen <pere>
Group Member
Fri 01 Nov 2013 07:32:43 AM UTC, original submission:  

Hello

I attached a patch for these types of reports:
Prefer prefix ++/-- operators for non-primitive types

Beware, I don't know if this may have some impact:
libbase/tree.hh:            leaf_iterator&  operator++();
libbase/tree.hh:            leaf_iterator   operator++(int);

Julien

Julien Nabet <julien2412>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #29522:  patch_cppcheck.txt added by julien2412 (20KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by pere (Posted a comment)
  • -email is unavailable- added by julien2412 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-01-16 pere StatusNone Done
        Open/ClosedOpen Closed
    2013-11-01 julien2412 Attached File- Added patch_cppcheck.txt, #29522

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code