patchGnash - The GNU Flash player - Patches: patch #8230, Patch for "Prefer prefix...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #8230: Patch for "Prefer prefix ++/-- operators" (from cppcheck)

Submitted by:  Julien Nabet <julien2412>
Submitted on:  Fri 01 Nov 2013 07:32:43 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: NoneOpen/Closed: Closed

Thu 16 Jan 2014 11:33:46 AM UTC, comment #5:

I've commited the patch.

Petter Reinholdtsen <pere>
Project Member
Thu 16 Jan 2014 11:10:13 AM UTC, comment #4:

I actually hadn't read the patch, just the original submission, which made me think tree.hh was touched. Now I red the patch and it seems good to me. Feel free to commit, thanks !

Sandro Santilli <strk>
Project Member
Thu 16 Jan 2014 10:49:28 AM UTC, comment #3:

The diffstat of the patch do not touch tree.hh, so I fail to see how the fact that it originates elsewhere should be relevant. Care to elaborate?

cygnal/libamf/amf.cpp | 8 ++++----
cygnal/libamf/amf_msg.cpp | 4 ++--
cygnal/libamf/element.cpp | 6 +++---
cygnal/libamf/flv.cpp | 4 ++--
cygnal/libamf/lcshm.cpp | 8 ++++----
cygnal/libamf/sol.cpp | 10 +++++-----
cygnal/libnet/cache.cpp | 8 ++++----
cygnal/libnet/cque.cpp | 6 +++---
cygnal/libnet/network.cpp | 2 +-
cygnal/libnet/rtmp.cpp | 2 +-
cygnal/libnet/rtmp_msg.cpp | 8 ++++----
cygnal/libnet/statistics.cpp | 2 +-
cygnal/rtmp_server.cpp | 2 +-
cygnal/testsuite/libamf.all/test_lc.cpp | 6 +++---
extensions/gtk2/gtkext.cpp | 2 +-
librender/opengl/Renderer_ogl.cpp | 2 +-
plugin/aos4/plugin.cpp | 2 +-
plugin/win32/plugin.cpp | 2 +-
18 files changed, 42 insertions(+), 42 deletions(-)

Petter Reinholdtsen <pere>
Project Member
Wed 15 Jan 2014 11:23:57 AM UTC, comment #2:

The only reason would be that tree.hh is not ours. Check headers, best reported upstream and upgraded once fixed, or any patch of ours would be replaced on upgrade.

Sandro Santilli <strk>
Project Member
Wed 15 Jan 2014 11:14:48 AM UTC, comment #1:

The change make sense to me. Any reason not to apply it? It applies fairly cleanly to the git HEAD (with one fuzzy).

Petter Reinholdtsen <pere>
Project Member
Fri 01 Nov 2013 07:32:43 AM UTC, original submission:

Hello

I attached a patch for these types of reports:
Prefer prefix ++/-- operators for non-primitive types

Beware, I don't know if this may have some impact:
libbase/tree.hh: leaf_iterator& operator++();
libbase/tree.hh: leaf_iterator operator++(int);

Julien

Julien Nabet <julien2412>

 

Attached Files
file #29522:  patch_cppcheck.txt added by julien2412 (20kB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by pere (Posted a comment)
  • -unavailable- added by julien2412 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 16 Jan 2014 11:33:46 AM UTCpereStatusNone=>Done
      Open/ClosedOpen=>Closed
    Fri 01 Nov 2013 07:32:43 AM UTCjulien2412Attached File-=>Added patch_cppcheck.txt, #29522

    Back to the top


    Powered by Savane 3.1-cleanup