patchGNU Octave - Patches: patch #8190, make __unimplemented__ recognize...

 
 

patch #8190: make __unimplemented__ recognize functions from toolboxes

Submitted by:  Carnë Draug <carandraug>
Submitted on:  Sat 28 Sep 2013 06:20:17 PM UTC  
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 29 Sep 2013 05:01:22 AM UTC, comment #2: 

After permission from jwe on IRC, I have pushed this patch. However, I still don't know what to do with the perl script that generates the list and can be useful again in the future as matlab implements new functions or we want to expand the list to other packages. I'm just leaving it here by now.

My guess is that it could also be useful to update the list of missing core functions.

Carnë Draug <carandraug>
Project Member
Sat 28 Sep 2013 07:05:44 PM UTC, comment #1: 

After talking with jwe on IRC, I have updated the perl script to skip functions we already have in Octave core. These functions were appearing in the list of package list because they were either overloaded (such as plot appearing as a financial function because it was overloaded for the financial time series class) or have simply been implemented in core (such as ntsc2rgb).

I'm uploading a new patch a new perl script to generate the lists.

(file #29257, file #29258)

Carnë Draug <carandraug>
Project Member
Sat 28 Sep 2013 06:20:17 PM UTC, original submission:  

I expanded _unimplemented_ to also recognize functions that belong to a Matlab toolbox and to warn about installing the corresponding Octave Forge package.

In addition, it also checks if the package is installed but not loaded to fix the very frequent complain about missing functions even though the packages are installed.

I have attached the patch I intend to push and the perl script I used to get the list of functions from the online documentation (where can I place it so it can be used again in the future?).

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #29258:  unimplemented.patch added by carandraug (29KiB - text/x-patch)
file #29257:  matlab_toolbox_function_list.pl added by carandraug (2KiB - application/x-perl)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-09-29 carandraug StatusNone => Done
        Open/ClosedOpen => Closed
    2013-09-28 carandraug Attached File- => Added matlab_toolbox_function_list.pl, #29257
        Attached File- => Added unimplemented.patch, #29258
    2013-09-28 carandraug Attached File#29255 => Removed
    2013-09-28 carandraug Attached File#29254 => Removed
    2013-09-28 carandraug Attached File- => Added unimplemented.patch, #29254
        Attached File- => Added matlab_toolbox_function_list.pl, #29255

    Back to the top


    Powered by Savane 3.5