patchGNU Octave - Patches: patch #8169, Patch to allow openmpi_ext package...

 
 

patch #8169: Patch to allow openmpi_ext package to build against openmpi 1.5+

Submitted by:  Alexander Hansen <alexkhansen>
Submitted on:  Sat 24 Aug 2013 06:45:40 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 10 Nov 2013 08:20:41 AM UTC, comment #6:

I'm closing this as the mpi package is now out and includes this fix.
c.

Carlo de Falco <cdf>
Project Member
Sun 27 Oct 2013 04:10:53 PM UTC, comment #5:

It worked for me.

octave:1> pkg -forge install mpi
MPI_Probe.cc:111:1: warning: control may reach end of non-void function
[-Wreturn-type]
}
^
1 warning generated.

Alexander Hansen <alexkhansen>
Wed 23 Oct 2013 10:00:54 PM UTC, comment #4:

Has this bug been fixed with the release of the MPI (not openMPI dependent) package?

Carnë Draug <carandraug>
Project Member
Thu 29 Aug 2013 11:30:13 AM UTC, comment #3:

Hi,

Yes I asked Alexander to share his patch, as I was not sure
it was related to this particular problem.

As I said in previous discussions [1] a cleaner solution to this issue would be to avoid accessing private fields of the MPI_Status structure but rather to define a wrapper class and only access the structure via public methods.

For the moment I suggest to remove MPI_probe from the package as it is non essential and creates a lot of compatibility problems.

I've posted a message on the list about this this morning.

c.

Carlo de Falco <cdf>
Project Member
Sun 25 Aug 2013 04:38:32 PM UTC, comment #2:

Sorry about the duplication. Carlo asked if I could post what I was using, so I didn't think to look for a similar item.

The fix should be generalized, but I didn't happen to have a general patch since I'm working only with the openmpi version as provided in the Fink distribution.

Alexander Hansen <alexkhansen>
Sun 25 Aug 2013 04:15:24 PM UTC, comment #1:

Duplicate of bug #39816.

Shouldn't this be fixed some other way so it still builds with older versions of openmpi?

Carnë Draug <carandraug>
Project Member
Sat 24 Aug 2013 06:45:40 PM UTC, original submission:

When building against openmpi-1.5 or later, the following error occurs. I've seen this on OS X using Fink, but the error is a missing member, and seems like it should occur elsewhere, too:

/sw/bin/mkoctfile-3.6.4 -I/sw/include/openmpi/opal/mca/hwloc/hwloc132/hwloc/include -I/sw/include -I/sw/include/openmpi -L/sw/lib/openmpi -lmpi_cxx -lmpi -lm MPI_Iprobe.cc
MPI_Iprobe.cc:38:14: error: no member named '_count' in 'ompi_status_public_t';
did you mean '_ucount'?
tmp = stat._count;
^~~~~~
_ucount
/sw/include/mpi.h:346:12: note: '_ucount' declared here
size_t _ucount;
^
1 error generated.

I used the following patch to address this:

diff -Nurd openmpi_ext/src/MPI_Iprobe.cc openmpi_ext.patched/src/MPI_Iprobe.cc
--- openmpi_ext/src/MPI_Iprobe.cc 2012-08-29 09:54:42.000000000 -0700
+++ openmpi_ext.patched/src/MPI_Iprobe.cc 2013-08-24 11:36:12.000000000 -0700
@@ -35,7 +35,7 @@
map.assign ("tag", tmp );
tmp = stat.MPI_ERROR;
map.assign ("err", tmp );
- tmp = stat._count;
+ tmp = stat._ucount;
map.assign ("cnt", tmp);
tmp = stat._cancelled;
map.assign ("can", tmp);
diff -Nurd openmpi_ext/src/MPI_Probe.cc openmpi_ext.patched/src/MPI_Probe.cc
--- openmpi_ext/src/MPI_Probe.cc 2012-08-29 09:54:42.000000000 -0700
+++ openmpi_ext.patched/src/MPI_Probe.cc 2013-08-24 11:36:12.000000000 -0700
@@ -34,7 +34,7 @@
map.assign ("tag", tmp);
tmp = stat.MPI_ERROR;
map.assign ("err", tmp);
- tmp = stat._count;
+ tmp = stat._ucount;
map.assign("cnt", tmp);
tmp = stat._cancelled;
map.assign("can", tmp);

Alexander Hansen <alexkhansen>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cdf (Posted a comment)
  • -unavailable- added by alexkhansen (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 10 Nov 2013 08:20:41 AM UTCcdfOpen/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1