patchGNUstep - Patches: patch #8118, Implementation of...

Group
 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8118: Implementation of NSInvocationOperation

Submitter:  Graham Lee <leeg>
Submitted:  Tue 09 Jul 2013 03:12:37 PM UTC
   
 
Category:  Foundation Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Wed 10 Jul 2013 02:20:04 PM UTC, comment #3: 

Thanks very much for the testcases.

I added them, checked their operation on OSX, and made a small fix (to type encoding comparison) so they all pass on my system.

Richard Frith-Macdonald <CaS>
Group Member
Tue 09 Jul 2013 07:10:48 PM UTC, comment #2: 

I have them, not sure how robust due to their use of operation queues. Some of them use the wait-until-done method so they're probably reliable. I'll adapt them to the test suite tomorrow.

Graham Lee <leeg>
Tue 09 Jul 2013 07:01:53 PM UTC, comment #1: 

Thanks very much ... near enough perfect.
I applied that (the only real change was to make the ivars private and add one to allow for future expansion without breaking binary compatibility).

Pushing my luck ... If you have testcases we could put into the testsuite, that would be great too.

Richard Frith-Macdonald <CaS>
Group Member
Tue 09 Jul 2013 03:12:37 PM UTC, original submission:  

Hi, I needed NSInvocationOperation in -base so I had a go at implementing it. I expect there might be style things or other issues but I'm happy to work on them to bring it into a state where it can be added to the library, please let me know what changes you need.

I've tried various happy and unhappy conditions in both Mac OS X (10.8.4) and Linux (Ubuntu 13.04, with -base from SVN trunk and this patch) and got common behaviour.

Thanks,
Graham.

Graham Lee <leeg>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #28529:  nsinvop-tests.patch added by leeg (4KiB - text/x-patch - Here are the tests. Again, I've tried to follow the existing examples.)
file #28522:  nsinvop.patch added by leeg (7KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by CaS (Posted a comment)
  • -email is unavailable- added by leeg (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-07-10 leeg Attached File- Added nsinvop-tests.patch, #28529
    2013-07-09 CaS StatusNone Done
        Open/ClosedOpen Closed
    2013-07-09 leeg Attached File- Added nsinvop.patch, #28522

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code