patchGnash - The GNU Flash player - Patches: patch #7961, Fix for issues with youtube in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7961: Fix for issues with youtube in NetStream_as.cpp

Submitted by:  George Thomas <georgethomas>
Submitted on:  Fri 01 Mar 2013 11:47:12 AM UTC  
 
Category:  core Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Sandro Santilli <strk> Open/Closed:  Closed

Thu 05 Sep 2013 10:43:40 AM UTC, comment #4:

Yeah sure it can be.

George Thomas <georgethomas>
Project Member
Wed 04 Sep 2013 08:53:10 PM UTC, comment #3:

Can this be closed ? I believe the class vs. instance variable thing has been sorted out and put under testing.

George: your call, I guess.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 01 Mar 2013 10:08:36 PM UTC, comment #2:

I dug into the new testsuite failures caused by these last two patches. The basics of these patches appears correct, but part of the problem is the support for these isn't implemented in NetStream. For example, NetStream::getCurrentFPS() is hardcoded to always return 0. There are some weird behaviours going on as well. Although these are readonly properties, the current NetStream.as test case tries to set them to both a string and boolean value, and then expects the return value when the NetStream isn't connected to be the same as the object it was previous set too. When the test case is run with the Adobe player, it has this behaviour, so the tests pass. I'm not sure if that needs to be the same behaviour in Gnash. The support for these new properties needs to be implemented before most of these tests will pass.

Rob Savoye <rsavoye>
Project Administrator
Fri 01 Mar 2013 07:26:04 PM UTC, comment #1:

Committed as of #e309f67f4436abd1fa7d31981b556ee66052113e.

Rob Savoye <rsavoye>
Project Administrator
Fri 01 Mar 2013 11:47:12 AM UTC, original submission:

Converting prototype members into members of the object when flash7 and above are used.

http://lists.gnu.org/archive/html/gnash-dev/2013-02/msg00017.html

Updated the test cases. Added xfail for livedelay as it has not yet been implemented.

George Thomas <georgethomas>
Project Member

 

Attached Files
file #27551:  youtubefix.patch added by georgethomas (3KiB - text/x-patch - patch in p1 format)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by rsavoye (Updated the item)
  • -email is unavailable- added by georgethomas (Submitted the item)
  • -email is unavailable- added by georgethomas (Converting prototype members into members of the object when swf7 and above are used for netstream.)
  • -email is unavailable- added by georgethomas (Converting prototype members into members of the object when swf7 and above are used for netstream.)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-09-05 strk StatusIn Progress => Done
        Assigned torsavoye => strk
        Open/ClosedOpen => Closed
    2013-03-01 rsavoye StatusDone => In Progress
        Open/ClosedClosed => Open
    2013-03-01 rsavoye StatusWorks For Me => Done
        Assigned toNone => rsavoye
        Open/ClosedOpen => Closed
    2013-03-01 georgethomas Attached File- => Added youtubefix.patch, #27551
        Carbon-Copy- => Added -email is unavailable-
        Carbon-Copy- => Added -email is unavailable-

    Back to the top


    Powered by Savane 3.3