patchGNU Octave - Patches: patch #7738, Fix typos and errors in new bessel...

 
 

patch #7738: Fix typos and errors in new bessel function tests

Submitter:  Mike Miller <mtmiller>
Submitted:  Sat 10 Mar 2012 09:07:16 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  jordigh Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 11 Mar 2012 06:11:48 PM UTC, comment #1: 

Thanks, pushed and merged in:

    http://hg.savannah.gnu.org/hgweb/octave/graph/55fcb6b575bb

I was wondering if there were some errors in the test themselves. I'm CC'ing Robert T. Short to confirm that this is the right fix.

Jordi GutiƩrrez Hermoso <jordigh>
Group Member
Sat 10 Mar 2012 09:07:16 PM UTC, original submission:  

Please try out the attached patch to the recent new tests added by Robert T. Short (cc'ed for comment as well).  I pulled out my copy of Abramowitz & Stegun to double check the failing tests and found some missing negative signs.  Also one of the calls to besselk was missing the last argument.

I also think the tolerance on the modified Bessel functions is too tight, which is why it was failing for me, so I doubled it, see if that works for you, but may still be too small.  For example, A&S Table 9.8 has besselk(2,20,1) only to 8 significant digits and a tolerance of 1e-8 just doesn't make sense.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #25316:  octave-ab4676288414.patch added by mtmiller (6KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by jordigh
  • -email is unavailable- added by jordigh
  • -email is unavailable- added by mtmiller (Submitted the item)
  • -email is unavailable- added by mtmiller
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-03-11 jordigh StatusNone Done
        Assigned toNone jordigh
        Open/ClosedOpen Closed
    2012-03-11 jordigh Carbon-Copy- Added "robert t. short" <octave@phaselockedsystems.com>
        Carbon-Copy- Added
    2012-03-10 mtmiller Attached File- Added octave-ab4676288414.patch, #25316
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code