patchGNU Octave - Patches: patch #7708, use news as command

 
 

patch #7708: use news as command

Submitted by:  Carnë Draug <carandraug>
Submitted on:  Thu 26 Jan 2012 11:48:59 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: Wont DoPrivacy: Public
Assigned to: NoneOpen/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 21 Oct 2013 09:58:28 PM UTC, comment #6:

You're right. Seems I did it with cset 3a93af21d206 when I was changing news() to share code with citation().

I have just pushed the other part than changes the syntax after installing a package (cset 8dd280b64de1).

Carnë Draug <carandraug>
Project Member
Mon 21 Oct 2013 06:06:28 PM UTC, comment #5:

I think that syntax change has already been done. If I do 'help news' it lists the command form already.

Rik <rik5>
Project Administrator
Mon 21 Oct 2013 06:02:06 PM UTC, comment #4:

ok. But aside changing "Function File" to "Command" in deftypefn, can I push a change that makes the rest of the changes? I think it's much more natural the command syntax in this case.

Carnë Draug <carandraug>
Project Member
Mon 21 Oct 2013 04:21:42 PM UTC, comment #3:

We will be getting rid of "Function File" and "Command" categories at the beginning of the line in documentation strings, so I'm going to close this patch.

Rik <rik5>
Project Administrator
Mon 30 Jan 2012 01:47:26 PM UTC, comment #2:

I know the part about all functions behaving that way. But because it looked to me that it has a similar behavior or use as the 'help' command, I thought I would change it for consistency. I just don't know what defines a function versus a command.

If this change is ever made, the new patch also changes deftypefn from "Function File" to "Command".

(file #24923)

Carnë Draug <carandraug>
Project Member
Thu 26 Jan 2012 06:13:45 PM UTC, comment #1:

ALL functions that take character string arguments may be called as "commands". Listing them that way in the docs is OK, but then people don't understand that it is possible to call them with the function-style syntax.

I'm not sure of the best way to handle this, but I think it should be done consistently for all functions that are commonly called with command-style syntax.

John W. Eaton <jwe>
Project Administrator
Thu 26 Jan 2012 11:48:59 AM UTC, original submission:

I thought that "news" can be used without parentheses, similarly to the help command. As such, I just have a very simple changeset to remove them from the help text (and the displayed message from pkg).

Carnë Draug <carandraug>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24923:  news-usage-v2.patch added by carandraug (1kB - text/x-patch)
file #24896:  news-usage.patch added by carandraug (1kB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by jwe (Posted a comment)
  • -unavailable- added by carandraug (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 21 Oct 2013 04:21:42 PM UTCrik5StatusNone=>Wont Do
      Open/ClosedOpen=>Closed
    Mon 30 Jan 2012 01:47:26 PM UTCcarandraugAttached File-=>Added news-usage-v2.patch, #24923
    Thu 26 Jan 2012 11:49:00 AM UTCcarandraugAttached File-=>Added news-usage.patch, #24896

    Back to the top


    Powered by Savane 3.1-cleanup