patchGNU Octave - Patches: patch #7660, specify package in news

 
 

patch #7660: specify package in news

Submitter:  Carnë Draug <carandraug>
Submitted:  Thu 03 Nov 2011 12:27:16 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  jordigh Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 15 Nov 2011 12:26:06 AM UTC, comment #5: 

Thank you. I have pushed these patches:

http://hg.savannah.gnu.org/hgweb/octave/graph/7908b27de857

Jordi Gutiérrez Hermoso <jordigh>
Group Member
Sat 12 Nov 2011 07:38:18 PM UTC, comment #4: 

I noticed that there was a bug. If someone gave no argument to get the default behavior (see core news) but the function couldn't find the NEWS file, the function would fail since package would be undefined (it was checking it's value to decide between error messages).

This patch fixes this and also makes the input check simpler.

(file #24363)

Carnë Draug <carandraug>
Group Member
Sat 12 Nov 2011 07:11:34 PM UTC, comment #3: 

here it is. I don't know, I must have messed it up when I tried to use the mq extension. Also, looking into the file, it is the same thing repeated 4 times. Don't know how that happened. Hope the second patch also applies.

(file #24362)

Carnë Draug <carandraug>
Group Member
Sat 12 Nov 2011 04:14:31 AM UTC, comment #2: 

The news.diff patch doesn't seem to apply, and its hash is wrong. Did you manually modify it after doing "hg export -r patchrev -o news.diff" ? Can you please submit it again?

Jordi Gutiérrez Hermoso <jordigh>
Group Member
Sat 05 Nov 2011 05:33:26 PM UTC, comment #1: 

After mentioning it on the octave-maintainers mailing list, here's the patch to make news look for the NEWS file into the 'packinfo' dir instead of doc. This also changes pkg to look for this file into the package root.

Since the GNU standards mention that old entries of NEWS file can be moved into a ONEWS file, I also added support for it.

I modifed the package sectino of the octave manual to mention this, and also added an entry for the ChangeLog file (previously undocumented but supported by pkg).

I made a small change to pkg.m that removed a bit of duplicated code.

Note that this patch will only apply after applyig the previous one.

(file #24305)

Carnë Draug <carandraug>
Group Member
Thu 03 Nov 2011 12:27:16 PM UTC, original submission:  

Hi

I have modifed the news function to accept a package name and also display the NEWS file from that package. I have attached the changeset.

Carnë

Carnë Draug <carandraug>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #24363:  news_bugfix2.diff added by carandraug (1KiB - text/x-patch - bug fix and simplication)
file #24362:  news_b81e0b3fedab.diff added by carandraug (2KiB - text/x-patch - remake of the 1st changeset)
file #24305:  more-news.diff added by carandraug (8KiB - text/x-patch - will only apply after the previous patch)
file #24283:  news.diff added by carandraug (8KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-11-15 jordigh StatusNone Done
        Assigned toNone jordigh
        Open/ClosedOpen Closed
    2011-11-12 carandraug Attached File- Added news_bugfix2.diff, #24363
    2011-11-12 carandraug Attached File- Added news_b81e0b3fedab.diff, #24362
    2011-11-05 carandraug Attached File- Added more-news.diff, #24305
    2011-11-03 carandraug Attached File- Added news.diff, #24283

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code