Gnash - The GNU Flash player - Patches: patch #7585, Removing parse parameter from...
You are not allowed to post comments on this tracker with your current authentication level.
patch #7585: Removing parse parameter from AudioDecoder interface
Submitter: | Jonas 'Sortie' Termansen <sortie> | ||
Submitted: | Wed 27 Jul 2011 07:45:23 PM UTC | ||
Category: | sound | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | strk | Open/Closed: | Closed |
Jump to the original submission
Thu 28 Jul 2011 03:39:15 PM UTC, comment #7: |
Sandro Santilli <strk> |
Thu 28 Jul 2011 02:28:55 PM UTC, comment #6: I reuploaded the patch rebased on master. |
Jonas 'Sortie' Termansen <sortie> |
Thu 28 Jul 2011 02:12:04 PM UTC, comment #5: FFmpeg version SVN-r0.5.1-4:0.5.1-1ubuntu1.1
|
Sandro Santilli <strk> |
Thu 28 Jul 2011 11:20:42 AM UTC, comment #4: I very carefully checked every implementation of the decode() function to see that the parameter was used. Only AudioDecoderFfmpeg used it. Thus, any other backends will work as usual.
|
Jonas 'Sortie' Termansen <sortie> |
Thu 28 Jul 2011 09:22:37 AM UTC, comment #3: Note that I get a single XPASS with your tests:
|
Sandro Santilli <strk> |
Thu 28 Jul 2011 09:05:26 AM UTC, comment #2: I've seen that you consider a failing parser constructor as the sign of having no need to parse... but how do you distinguish between no-need and an actual failure ? |
Sandro Santilli <strk> |
Thu 28 Jul 2011 08:22:45 AM UTC, comment #1: Was this tested with both embedded and external sounds ?
|
Sandro Santilli <strk> |
Wed 27 Jul 2011 07:45:23 PM UTC, original submission:
The parse parameter used in the "uint8_t* decode(uint8_t* input, uint32_t inputSize, uint32_t& outputSize, uint32_t& decodedData, bool parse)" function in AudioDecoder is not needed.
|
Jonas 'Sortie' Termansen <sortie> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2011-07-28 | strk | Status | None | Done | |
Assigned to | None | strk | |||
Open/Closed | Open | Closed | |||
2011-07-28 | sortie | Attached File | - | Added 0001-Removed-parse-parameter-from-AudioDecoder-interface.patch, #23711 | |
2011-07-28 | sortie | Attached File | #23704 | Removed | |
2011-07-27 | sortie | Attached File | - | Added 0001-Removed-parse-parameter-from-AudioDecoder-interface.patch, #23704 | |
Carbon-Copy | - | Added strk |
Powered by Savane 3.13-758e.
Corresponding source code
Pushed
http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=7589e32ae3641ae47d7f5eb8ba1fc577feccf21a