patchGNU Autoconf Archive - Patches: patch #7556, Unify the plethora of different...

 
 

patch #7556: Unify the plethora of different compiler flag checking macros

Submitter:  Maarten Bosmans <mkbosmans>
Submitted:  Thu 16 Jun 2011 03:03:10 PM UTC
   
 
Priority:  5 - Normal Status:  Done
Assigned to:  simons Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 28 Jun 2011 10:54:18 AM UTC, comment #3: 

I'm closing this item, because it doesn't relate to a specific patch or macro anymore.

Peter Simons <simons>
Group administrator
Tue 21 Jun 2011 08:48:36 AM UTC, comment #2: 

I posted this bug report a bit to early. After some more digging in the macros it appears that there are a lot of macros that can be obsoleted. I think you can regard my series of emails as superseeding this bug report and put the patch on hold for now.

We need to view all the patches holisticly and come to a solution. The same issue is for the CXX, CPP, CPPCXX and LD variant of this macro. As I noted in the mail to the list, these macros have a subtle difference with AX_CHECK_COMPILER_FLAGS in that they do not test the given flag in addition to the standard CFLAGS, but try to compile the test program with only the given flag. (I only discovered that after opening this bug report)

Maarten Bosmans <mkbosmans>
Tue 21 Jun 2011 08:25:29 AM UTC, comment #1: 

Yes, I agree that it looks like AX_C_CHECK_CFLAG can be replaced by AX_CHECK_COMPILER_FLAGS. An appropriate patch is attached below.

Francesco, how do you feel about this issue? Are there unique use-cases for AX_C_CHECK_CFLAG that we have overlooked?

(file #23543)

Peter Simons <simons>
Group administrator
Thu 16 Jun 2011 03:03:10 PM UTC, original submission:  

As far as I can see the ax_c_check_flag macro is not needed anymore, since ax_check_compiler_flags is more generic and better written.

AX_C_CHECK_FLAG(flag)
can be replaced by
AC_LANG_PUSH([C])
AX_CHECK_COMPILER_FLAGS(flag)
AC_LANG_POP()

Should ax_c_check_flag be removed or obsoleted?

Maarten Bosmans <mkbosmans>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Updated the item)
  • -email is unavailable- added by mkbosmans (Submitted the item)
  •  

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-06-28 simons StatusIn Progress Done
        Open/ClosedOpen Closed
    2011-06-25 simons Summaryax_c_check_flag not needed anymore? Unify the plethora of different compiler flag checking macros
    2011-06-21 simons Attached File- Added 0001-AX_C_CHECK_FLAG-deprecated-in-favor-of-AX_CHECK_COMP.patch, #23543
        StatusNone In Progress
        Assigned toNone simons

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code