patchCompact Disc Input and Control Library - Patches: patch #7532, CD-TEXT binary fields, charcode...

 
 

patch #7532: CD-TEXT binary fields, charcode detection

Submitter:  None
Submitted:  Fri 22 Apr 2011 09:28:11 AM UTC
   
 
Category:  libcdio Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  rocky Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 23 Apr 2011 07:00:20 PM UTC, comment #1: 

Should be in git commit  610a915. Some small changes were made.

For example #defines in cdtext_private.h was turned in to an enum because that makes it more clear inside a debugger what the meaning of the numbers is and what category of thing the number is.

Please double check that this works for you.

My main concern is that still there are no test for any of the code added.

Also, I'd appreciate it if future changes followed these style guidelines:

  Please use tabs for indenting code. Tab spacing is nonstandard.
  Instead expand the tabs to space.

  Please follow existing C coding conventions. For example
  headers often have doxygen comments where appropriate, like /*!

Rocky Bernstein <rocky>
Group administrator
Fri 22 Apr 2011 09:28:11 AM UTC, original submission:  

+discid field extraction
+genre field extraction (experimental)
+blocksize field extraction
+read charcode from blocksize field
*some unneeded comments removed
*unneeded local variables removed
*typos

2DO:
charcode information is currently just a local value, should be made accessible through a public function.
read language value and convert to 3char language key

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #23290:  cdtext_private.h.patch added by None (5KiB - application/octet-stream - see email at libcdio-dev)
file #23291:  cdtext.c.patch added by None (6KiB - application/octet-stream - see email at libcdio-dev)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rocky (Updated the item)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-04-23 rocky StatusNone Done
        Assigned toNone rocky
        Open/ClosedOpen Closed
    2011-04-22 None Attached File- Added cdtext_private.h.patch, #23290
        Attached File- Added cdtext.c.patch, #23291

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code