patchGNU nano - Patches: patch #7021, SVN r4459: Fix shortcut display...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7021: SVN r4459: Fix shortcut display inconsistencies in bottombars()

Submitter:  David Lawrence Ramsey <dolorous>
Submitted:  Tue 08 Dec 2009 05:14:10 PM UTC
   
 
Priority:  5 - Normal Status:  Done
Privacy:  Public Assigned to:  astyanax
Open/Closed:  Closed Release:  2.3

Fri 14 Jun 2013 02:45:45 AM UTC, comment #3: 

LGTM.  Applied in 4579, thanks David!

Chris Allegretta <astyanax>
Group administrator
Thu 23 May 2013 06:29:32 PM UTC, comment #2: 

Resynced the patch with trunk SVN 4575.

(file #28150)

David Lawrence Ramsey <dolorous>
Group Member
Fri 11 Dec 2009 06:41:39 AM UTC, comment #1: 

This one we only need to postpone until after 2.2.1 is released either tomorrow or Saturday, so we can make a prerelease of 2.2.2 and get additional testers, hopefully.

Chris Allegretta <astyanax>
Group administrator
Tue 08 Dec 2009 05:14:10 PM UTC, original submission:  

In trunk SVN r4459, there are a few oddities with the shortcuts displayed in bottombars(), compared to the help browser.

First, if more than one meta sequence is bound to the same function, the last sequence is displayed instead of the first.  For example, in the help browser, "First Line" is displayed as "M-\", with "M-|" as an alternative, but "First File" in the file browser, which uses the same shortcuts, is displayed as "M-|".

Second, if both a function key and a meta sequence are bound to the same function, the function key is displayed instead of the meta sequence.  For example, in the help browser, "WhereIs Next" is displayed as "M-W", with "F16" as an alternative, but "WhereIs Next" in the file browser is displayed as "F16".

The attached patch rearranges find_first_sc() a bit to make it match the help browser's logic.  Note that it's somewhat experimental and probably needs to be looked over, mostly with regard to rebinding keys; despite the revised comment, I don't actually know whether e.g. binding a function key first to one of the arrow keys is problematic.

David Lawrence Ramsey <dolorous>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #28150:  shortcutdisplay4575.patch added by dolorous (2KiB - application/octet-stream)
file #19223:  shortcutdisplay4459.patch added by dolorous (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by astyanax (Posted a comment)
  • -email is unavailable- added by dolorous (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-06-14 astyanax StatusPostponed Done
        Open/ClosedOpen Closed
    2013-05-23 dolorous Attached File- Added shortcutdisplay4575.patch, #28150
    2010-02-09 astyanax ReleaseNone 2.3
    2009-12-11 astyanax StatusNone Postponed
        Assigned toNone astyanax
    2009-12-08 dolorous Attached File- Added shortcutdisplay4459.patch, #19223

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code