patchGNU nano - Patches: patch #7021, SVN r4459: Fix shortcut display...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #7021: SVN r4459: Fix shortcut display inconsistencies in bottombars()

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Tue 08 Dec 2009 05:14:10 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Chris Allegretta <astyanax>Open/Closed: Closed
Release: 2.3

Fri 14 Jun 2013 02:45:45 AM UTC, comment #3:

LGTM. Applied in 4579, thanks David!

Chris Allegretta <astyanax>
Project AdministratorIn charge of this item.
Thu 23 May 2013 06:29:32 PM UTC, comment #2:

Resynced the patch with trunk SVN 4575.

(file #28150)

David Lawrence Ramsey <dolorous>
Project Administrator
Fri 11 Dec 2009 06:41:39 AM UTC, comment #1:

This one we only need to postpone until after 2.2.1 is released either tomorrow or Saturday, so we can make a prerelease of 2.2.2 and get additional testers, hopefully.

Chris Allegretta <astyanax>
Project AdministratorIn charge of this item.
Tue 08 Dec 2009 05:14:10 PM UTC, original submission:

In trunk SVN r4459, there are a few oddities with the shortcuts displayed in bottombars(), compared to the help browser.

First, if more than one meta sequence is bound to the same function, the last sequence is displayed instead of the first. For example, in the help browser, "First Line" is displayed as "M-\", with "M-|" as an alternative, but "First File" in the file browser, which uses the same shortcuts, is displayed as "M-|".

Second, if both a function key and a meta sequence are bound to the same function, the function key is displayed instead of the meta sequence. For example, in the help browser, "WhereIs Next" is displayed as "M-W", with "F16" as an alternative, but "WhereIs Next" in the file browser is displayed as "F16".

The attached patch rearranges find_first_sc() a bit to make it match the help browser's logic. Note that it's somewhat experimental and probably needs to be looked over, mostly with regard to rebinding keys; despite the revised comment, I don't actually know whether e.g. binding a function key first to one of the arrow keys is problematic.

David Lawrence Ramsey <dolorous>
Project Administrator

 

Attached Files
file #28150:  shortcutdisplay4575.patch added by dolorous (2kB - application/octet-stream)
file #19223:  shortcutdisplay4459.patch added by dolorous (2kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by astyanax (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 14 Jun 2013 02:45:45 AM UTCastyanaxStatusPostponed=>Done
      Open/ClosedOpen=>Closed
    Thu 23 May 2013 06:29:32 PM UTCdolorousAttached File-=>Added shortcutdisplay4575.patch, #28150
    Tue 09 Feb 2010 02:23:43 AM UTCastyanaxReleaseNone=>2.3
    Fri 11 Dec 2009 06:41:39 AM UTCastyanaxStatusNone=>Postponed
      Assigned toNone=>astyanax
    Tue 08 Dec 2009 05:14:11 PM UTCdolorousAttached File-=>Added shortcutdisplay4459.patch, #19223

    Back to the top


    Powered by Savane 3.1-cleanup