patchPSPP - Patches: patch #6716, Improve "struct ccase"

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6716: Improve "struct ccase"

Submitter:  Ben Pfaff <blp>
Submitted:  Wed 07 Jan 2009 07:17:59 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Wed 07 Jan 2009 02:12:19 PM UTC, comment #2: 


>I can't see any obvious problems here.


Thanks.  That doesn't say whether you think it's a worthwhile improvement, but I guess it means that you don't strongly object.

I pushed this to master.

Ben Pfaff <blp>
Group administrator
Wed 07 Jan 2009 09:25:14 AM UTC, comment #1: 

I can't see any obvious problems here.

John Darrington <jmd>
Group administrator
Wed 07 Jan 2009 07:17:59 AM UTC, original submission:  

While I was working on making "union value" more flexible, I realized that struct ccase was too hard to work with.  The attached patch improves things, in my opinion, a great deal.  It also has the potential to make PSPP faster.

The patch includes a commit message that describes it in more detail.

It passes "make check" and doesn't add any valgrind warnings.  I didn't check that it didn't add memory leaks, because "valgrind" reported several unrelated leaks.  I'll go back and fix all of them in one go after this is checked in.

Comments?

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #17217:  foo.patch added by blp (229KiB - text/x-diff - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-01-07 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2009-01-07 blp Attached File- Added foo.patch, #17217

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code