patchPSPP - Patches: patch #6669, Simple patch which allows to...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6669: Simple patch which allows to specify which codepage to use in .sav files

Submitter:  Eric de Ruiter <jeric>
Submitted:  Wed 12 Nov 2008 08:58:40 AM UTC
   
 
Category:  None Item Group:  None
Status:  None Assigned to:  None
Open/Closed:  Closed

Thu 09 Apr 2009 08:21:20 AM UTC, comment #4: 

This is redundant now that we have implemented the SET LOCALE command.

John Darrington <jmd>
Group administrator
Fri 14 Nov 2008 12:37:46 PM UTC, comment #3: 

1. How does spss treat this field? Does it perform any recoding on the data or is it up to the user to make sure it's correct ?

2. Can you add this setting to the reference manual (doc/utilities.texi )

John Darrington <jmd>
Group administrator
Wed 12 Nov 2008 04:17:56 PM UTC, comment #2: 

Hi Ben,

With regard to the copyright, I have nu clue which papers you mean (this is the first time I contributed a patch to an opensource project). In my judgement this is a very simple small patch which is just a bit of copy/paste from the rest of the pspp code, the infrastructure was already there. I have no problem when this included in pspp.

With regard to the compile failure and testing: it did compile on my system (with gcc (GCC) 4.2.4 (Ubuntu 4.2.4-1ubuntu3)). And it works perfectly for me (tested with codepage=65001 (UTF8) and SPSS 16). It's probably a warning which is seen as an error in your version of GCC (or a change in the current svn version of pssp). The patch was against the 0.6.1 release.

I can submit an improved patch later this week, if it's needed.

Regards,

  Eric

Eric de Ruiter <jeric>
Wed 12 Nov 2008 03:56:18 PM UTC, comment #1: 

Hi Eric.  Thank you for the patch.

Do you have copyright assignment papers on file with the FSF?  This patch is just slightly too long, in my judgment, for us to apply it without papers.

Also, it is clear that the patch has not been tested: it will not compile due to a missing ; in the struct in sys-file-writer.h.  Do you plan to submit an improved patch when you have finished and tested this one?

Ben Pfaff <blp>
Group administrator
Wed 12 Nov 2008 08:58:40 AM UTC, original submission:  

Attached is a simple patch which allows you to set the codepage (sets the character_code field as specified here: http://www.gnu.org/software/pspp/pspp-dev/html_node/Machine-Integer-Info-Record.html#Machine-Integer-Info-Record)
The default is not changed (7-bit ascii).

Syntax:

SET codepage=<integer>.

For example use

  SET codepage=65001.

to set the codepage to UTF-8. I believe this works for SPSS versions >= 16.
This patch does not do recoding, so you have to make sure your data is in the specified codepage.

See also page 46 in http://support.spss.com/ProductsExt/SPSS/Documentation/Manuals/16.0/SPSS%20Input-Output%20Module.pdf

Eric de Ruiter <jeric>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #16833:  pspp.patch added by jeric (4KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jeric (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-04-09 jmd Open/ClosedOpen Closed
    2008-11-12 jeric Attached File- Added pspp.patch, #16833

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code