patchLet me illustrate... - Patches: patch #6597, use wxArtProvider for icons, 16x16...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6597: use wxArtProvider for icons, 16x16 icons for menus

Submitter:  Vaclav Slavik <vslavik>
Submitted:  Sun 03 Aug 2008 06:00:48 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Tue 13 Feb 2018 11:55:21 AM UTC, comment #2: 

Testing is deemed to have been completed.

Greg Chicares <chicares>
Group administrator
Thu 02 Oct 2008 02:12:11 AM UTC, comment #1: 

Committed between 20081001T2317Z and 20081002T0205Z.

Greg Chicares <chicares>
Group administrator
Sun 03 Aug 2008 06:00:48 PM UTC, original submission:  

This replaces all explicit references to XPM icons in XRC files by stock IDs (either standardized or LMI-specific) and implements wxArtProvider that uses correct icon sizes.

Icon files are converted from XPM to PNG files, too (as discussed on mailing list, they have alpha channel and so look better). If there's a 16x16 version of an icon ("-16" suffix), it is used instead of downscaling 24x24 version. For the unmodified icons from GNOME theme, I took the originals, for LMI-specific icons, I simply converted XPMs to PNGs, but that's temporary, it doesn't look good.

Not shown in the diff is removal of following XPMs:

about.xpm
close.xpm
default_cell.xpm
delete-row.xpm
edit-case.xpm
edit-cell.xpm
edit-class.xpm
exit.xpm
fixed-width.xpm
help.xpm
insert-rows.xpm
new.xpm
open.xpm
paste-case.xpm
preferences.xpm
print-case.xpm
print-cell.xpm
print-options.xpm
print-preview.xpm
print.xpm
run-case.xpm
run-cell.xpm
save.xpm
saveas.xpm
varying-width.xpm
write_spreadsheet.xpm

They are replaced with the following PNGs (included in attached tarball):

about-16.png
about.png
close-16.png
close.png
default-cell.png
delete-row-16.png
delete-row.png
edit-case.png
edit-cell.png
edit-class.png
file-open-16.png
file-open.png
file-save-16.png
file-save-as-16.png
file-save-as.png
file-save.png
fixed-width.png
help-16.png
help.png
icons.cpp
icons.hpp
insert-rows-16.png
insert-rows.png
new-16.png
new.png
paste-case.png
preferences-16.png
preferences.png
print-16.png
print-case.png
print-cell.png
print-options-16.png
print-options.png
print-preview-16.png
print-preview.png
print.png
quit-16.png
quit.png
run-case.png
run-cell.png
varying-width.png
write-spreadsheet.png

Of these, the following are not used, because they are only needed in menus, where the -16 versions are used:

about.png
close.png
print-options.png
quit.png

But I left them there in case we ever want to use configurable nonstandard menu item icons sizes.

Vaclav Slavik <vslavik>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #16232:  lmi-artprov.patch added by vslavik (30KiB - text/x-patch)
file #16233:  lmi-icons-png.tar.gz added by vslavik (30KiB - application/x-gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by chicares (Posted a comment)
  • -email is unavailable- added by vslavik (Submitted the item)
  • -email is unavailable- added by vslavik
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-02-13 chicares StatusReady For Test Done
        Assigned towboutin None
        Open/ClosedOpen Closed
    2008-10-02 chicares StatusNone Ready For Test
        Assigned toNone wboutin
    2008-08-03 vslavik Attached File- Added lmi-artprov.patch, #16232
        Attached File- Added lmi-icons-png.tar.gz, #16233
        Carbon-Copy- Added zeitlin

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code