patchPSPP - Patches: patch #6426, Patches needed for text import

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6426: Patches needed for text import

Submitted by:  Ben Pfaff <blp>
Submitted on:  Mon 18 Feb 2008 07:27:57 AM UTC  
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

( Jump to the original submission)

Wed 20 Feb 2008 10:07:41 AM UTC, comment #8: 

Done.

John Darrington <jmd>
Project Administrator
Wed 20 Feb 2008 05:08:06 AM UTC, comment #7: 

>This latest patch looks fine. Check it in when you're ready.


I checked it in.  Thanks!

I've now checked in all of my patches from this Savannah patch collection.  John, when you check in your version of var-sheet-add-features.patch, please mark this Savannah patch closed.

Ben Pfaff <blp>
Project Administrator
Wed 20 Feb 2008 04:54:13 AM UTC, comment #6: 

>Ben, can you try the attached patch (based on your
>var-sheet-add-features.patch).


This adds the feature that text-import wants, and I do not see any problems with it, although I confess that I did not read all of it carefully.  Please check it in when you are ready.

Ben Pfaff <blp>
Project Administrator
Tue 19 Feb 2008 08:53:58 AM UTC, comment #5: 

Ben, can you try the attached patch (based on your var-sheet-add-features.patch).

(file #15075)

John Darrington <jmd>
Project Administrator
Tue 19 Feb 2008 07:33:34 AM UTC, comment #4: 

This latest patch looks fine.  Check it in when you're ready.

John Darrington <jmd>
Project Administrator
Tue 19 Feb 2008 06:51:16 AM UTC, comment #3: 

John, I committed the four patches that you were happy with.  Here is a revised version of var-store-add-features.patch that makes the changes you requested, in case you want to look at the revised version.  And var-sheet-add-features.patch is on the back burner waiting for the edits that you are planning.

(file #15074)

Ben Pfaff <blp>
Project Administrator
Mon 18 Feb 2008 09:07:59 PM UTC, comment #2: 

Thank you for your comments.

>The var-sheet-add-features.patch is going to conflict badly with
>some edits I'm working on. Can you hold off on this one for a day
>or two.


No problem.  It's a conceptually simple change.  If I have to reimplement it, it's not a big deal for me.

>In var-store-add-features, I suggest that instead of a "for-input"
>property of boolean type, you use g_param_spec_enum to create a
>enumerated type property called "format-type" or something
>similar.


Will do.

>Instead of the declarations :
>int trailing_rows;
>bool for_input;
>
>can you write:
>
>gint trailing_rows;
>gboolean for_input;


I think that the glib typedefs for int and other standard types from C89 are a stupid idea that should never have seen the light of day.  There is some sense in gboolean, since C89 didn't have a boolean type.  But for consistency I'll change both of these.

Ben Pfaff <blp>
Project Administrator
Mon 18 Feb 2008 09:09:18 AM UTC, comment #1: 

The var-sheet-add-features.patch is going to conflict badly with some edits I'm working on.  Can you hold off on this one for a day or two.  I'll try to post a patch shortly and we can negotiate this.

In var-store-add-features, I suggest that instead of a "for-input" property of boolean type, you use g_param_spec_enum to create a enumerated type property called "format-type" or something similar.
Instead of the declarations :
  int trailing_rows;
  bool for_input;

can you write:

 gint trailing_rows;
 gboolean for_input;

I can't foresee any problems with any of the other patches.

John Darrington <jmd>
Project Administrator
Mon 18 Feb 2008 07:27:57 AM UTC, original submission:  

The attached patches are prerequisites for text import but can be reviewed separately in advance.  Let me know what you think.

These patches do not need to be applied in any particular order.

Ben Pfaff <blp>
Project Administrator

 

Attached Files
file #15075:  var-sheet-x.patch added by jmd (30KiB - text/x-diff)
file #15057:  var-store-add-features.patch added by blp (6KiB - text/x-diff)
file #15058:  var-sheet-add-features.patch added by blp (8KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-02-20 jmd StatusReady For Test/Review => Done
        Open/ClosedOpen => Closed
    2008-02-19 jmd Attached File- => Added var-sheet-x.patch, #15075
    2008-02-19 blp Attached File- => Added var-store-add-features-2.patch, #15074
    2008-02-19 blp Attached File#15062 => Removed
    2008-02-19 blp Attached File#15061 => Removed
    2008-02-19 blp Attached File#15059 => Removed
    2008-02-19 blp Attached File#15060 => Removed
    2008-02-18 blp Attached File- => Added var-add-more-defaults-functions.patch, #15061
        Attached File- => Added ds_read_line-add-max-width.patch, #15062
    2008-02-18 blp Attached File- => Added var-store-add-features.patch, #15057
        Attached File- => Added var-sheet-add-features.patch, #15058
        Attached File- => Added format-add-min-max-width-functions.patch, #15059
        Attached File- => Added format-add-max-numeric-width.patch, #15060

    Back to the top


    Powered by Savane 3.5