patchPSPP - Patches: patch #6347, Ignore missing values on long...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6347: Ignore missing values on long string variables in system files

Submitter:  Ben Pfaff <blp>
Submitted:  Mon 17 Dec 2007 01:34:34 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 03 Feb 2008 06:53:11 AM UTC, comment #4: 

Checked these in (finally), so I'm closing the bug.

Thanks to everyone for the reviews.

Ben Pfaff <blp>
Group administrator
Tue 18 Dec 2007 12:03:54 PM UTC, comment #3: 

The patches look good I haven't tried them.

I think the approach is correct. Let's worry about interpreting the new records at a later stage.  For now just read them and ignore (or warn) them.


John Darrington <jmd>
Group administrator
Tue 18 Dec 2007 03:17:03 AM UTC, comment #2: 


>I didn't check the patch much, but it compiled and
>passed the tests.


Thanks for trying it out.

As much as I was hoping for testing, I was also hoping for some comment on whether you and John agree that this is a reasonable solution for now, until we have a proper implementation of missing values and value labels for long string variables.  Do you have an opinion?

Ben Pfaff <blp>
Group administrator
Mon 17 Dec 2007 03:33:04 PM UTC, comment #1: 

I didn't check the patch much, but it compiled and
passed the tests.

Jason H Stover <jstover>
Group Member
Mon 17 Dec 2007 01:34:34 AM UTC, original submission:  

Currently, PSPP rejects system files that put missing values on long string variables.  SPSS 16, however, supports missing values on long string variables, and it appears to do so by using the existing field for missing values, thus PSPP needs a small fix to ignore them.

SPSS 16 also uses two new system file extension records (subtypes 20 and 21).  We can ignore these too.

Patch sys-file-long-string-missing-values.patch takes care of these  issues.

sys-file-reader-uninitialized-data-fix.patch fixes an unrelated problem that I noticed while reading code.

sys-dissect.patch adds a new tool "dissect-sysfile" that is useful for figuring out why PSPP might not like a system file, or at least viewing the system file's structure.

Comments?

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #14641:  sys-dissect.patch added by blp (26KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by jstover (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-02-03 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2007-12-17 blp Attached File- Added sys-file-long-string-missing-values.patch, #14639
        Attached File- Added sys-file-reader-uninitialized-data-fix.patch, #14640
        Attached File- Added sys-dissect.patch, #14641

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code