patchPSPP - Patches: patch #6058, update to GPLv3

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6058: update to GPLv3

Submitter:  Ben Pfaff <blp>
Submitted:  Sun 01 Jul 2007 02:56:12 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  blp
Open/Closed:  Closed

Sat 07 Jul 2007 06:24:13 AM UTC, comment #5: 

I checked this in, after making one change following discussion on gnu-prog: I dropped the -email is unavailable- email address and FSF mailing address from the per-file comments, because RMS (via Karl Berry) said that they weren't really necessary, and the mailing address in particular is a pain to update as it changes.

Ben Pfaff <blp>
Group administrator
Sun 01 Jul 2007 09:14:29 PM UTC, comment #4: 

Here's a revised patch that fixes #1 and #2.  I couldn't reproduce #3 so I'll assume that it's related to the patch format or application instead of what will actually show up in the checkin.

In the revised patch all source files have identical notices with the exception of copyright years and that I kept the distinction between PSPP and PSPPIRE.

Comments?

(file #13220)

Ben Pfaff <blp>
Group administrator
Sun 01 Jul 2007 04:08:22 AM UTC, comment #3: 

I'll make sure that #1 and #3 get investigated and fixed before checkin.

>2. For some reason, the line breaks in the header preambles are
>not consistent through all the files. (Some years ago RMS
>repremanded me for reformatting this text. He likes it copied
>verbatim.)


And here I was trying to disturb the fairly heterogeneous existing spacing conventions as little as possible.

Would you mind then if I just changed all of the license headers to be the same based on the GPLv3's authoritative text?  I think only the copyright years would need to be preserved from one file to the next.

Ben Pfaff <blp>
Group administrator
Sun 01 Jul 2007 03:57:06 AM UTC, comment #2: 

1.  You added some literal < and > characters to src/ui/gui/psppire.glade which causes libglade to object most severly.  These need to be changed to &lt; and &gt; respectively.

2.  For some reason, the line breaks in the header preambles are not consistent through all the files.  (Some years ago RMS repremanded me for reformatting this text.  He likes it copied verbatim.)

3.  Not sure how this happened, but after I applied your patches, ./COPYING ended up with  different words from those at http://www.gnu.org/licenses/gpl.txt ....

John Darrington <jmd>
Group administrator
Sun 01 Jul 2007 02:57:04 AM UTC, comment #1: 

Really attaching gplv3-upgrade.patch now.  It was too big uncompressed so I gzip'd it.

(file #13210)

Ben Pfaff <blp>
Group administrator
Sun 01 Jul 2007 02:56:12 AM UTC, original submission:  

gplv3-upgrade.patch updates all the PSPP-specific GPL notices to read version 3 or later.  I didn't update anything in lib/ because that's partially external code.  I also updated the paragraph in each notice to point to the GNU licensing webpage, which GPLv3 suggests we should do.

legal-update.patch updates the --version output to match what is recommended by the most recent GNU coding standards document.

Comments?

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #13220:  gplv3-upgrade-2.patch.gz added by blp (54KiB - application/gzip)
file #13210:  gplv3-upgrade.patch.gz added by blp (48KiB - application/gzip)
file #13209:  legal-update.patch added by blp (884B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-07-07 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2007-07-01 blp Attached File# Removed
    2007-07-01 blp Attached File# Removed
    2007-07-01 blp Attached File- Added gplv3-upgrade-2.patch.gz, #13220
    2007-07-01 jmd Assigned toNone blp
    2007-07-01 blp Attached File- Added gplv3-upgrade.patch.gz, #13210
    2007-07-01 blp Attached File- Added legal-update.patch, #13209

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code