patchPSPP - Patches: patch #6057, Transformation sigs etc.

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6057: Transformation sigs etc.

Submitter:  John Darrington <jmd>
Submitted:  Sun 01 Jul 2007 12:55:25 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 01 Jul 2007 03:18:37 AM UTC, comment #2: 

Done.

John Darrington <jmd>
Group administrator
Sun 01 Jul 2007 02:24:23 AM UTC, comment #1: 

You know, I certainly didn't intend to design the interface in such a confusing way.  I'd swear I had a good reason for doing it the way I did, at the time.  But I can't see any reason to keep it that way.  Please apply your patch.

I am a little nervous about exposing the dataset's transformations, though.  Would you mind delaying that part of it until the GUI work is ready?  I would like to see if we can avoid exposing dataset internals more than necessary.

Ben Pfaff <blp>
Group administrator
Sun 01 Jul 2007 12:55:25 AM UTC, original submission:  

This change (IMHO) makes the sig of trns_chain_execute more logical.

It also removes an assertion which I found was necessary for a future change (relating to gui work) which I've got waiting.  Also related to this work it introduces a dataset_trans function to return a pointer to the current transformation.

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #13208:  patch added by jmd (6KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-07-01 jmd StatusWorks For Me Done
        Assigned toblp None
        Open/ClosedOpen Closed
    2007-07-01 blp StatusReady For Test/Review Works For Me
    2007-07-01 jmd Attached File- Added patch, #13208

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code