patchPSPP - Patches: patch #5740, make q2c link under mingw32

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5740: make q2c link under mingw32

Submitter:  Ben Pfaff <blp>
Submitted:  Mon 12 Feb 2007 04:37:32 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Tue 13 Feb 2007 12:29:55 AM UTC, comment #2: 

The problem is that gnulib detects that mingw may have a problem with its implementation of localtime, so it puts
       #define localtime rpl_localtime
in config.h.  Thus, if you use localtime but don't link against gnulib, you get a linker error.

I've checked this in.

Ben Pfaff <blp>
Group administrator
Mon 12 Feb 2007 03:17:35 PM UTC, comment #1: 

I thought localtime was a C89 function, so I don't see why it should have been a problem.  But like you say, it probably wasn't usefull, so dropping it can't do any harm.

John Darrington <jmd>
Group administrator
Mon 12 Feb 2007 04:37:32 AM UTC, original submission:  

Make q2c link under mingw32, by eliminating the dependency on localtime.  Gnulib replaces localtime by a fixed version, but we don't link q2c against gnulib.  q2c only uses localtime to put the time of processing into the output file, which I've never in practice found to be useful, so the patch just drops this feature.

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11967:  q2c.patch added by blp (2KiB - text/x-patch - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-02-13 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2007-02-12 blp Attached File- Added q2c.patch, #11967

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code