patchPSPP - Patches: patch #5661, More dictionary callbacks

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5661: More dictionary callbacks

Submitter:  John Darrington <jmd>
Submitted:  Sat 06 Jan 2007 11:48:51 PM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 07 Jan 2007 04:08:06 AM UTC, comment #2: 

Thanks.  I've attended to these things and committed.

John Darrington <jmd>
Group administrator
Sun 07 Jan 2007 01:15:17 AM UTC, comment #1: 

Looks good.

I suspect that dict_unset_split_var should only call the callback if d->split_cnt changes; otherwise, it will be called every time a variable is deleted from the dictionary, regardless of whether the variable is actually a split variable.

I agree that proc_cancel_temporary_transformations should ensure that the old dictionary gets destroyed, but I think that actually dataset_set_dict should be the one to do it.  dataset_set_dict has only 3 existing callers, and all of them destroy the old dictionary just before calling it, so this will drop a line of code from each caller too.

>I'm posting this patch in case I've done anything evil in src/data/dictionary.c or src/data/procedure.c


No worries.

Ben Pfaff <blp>
Group administrator
Sat 06 Jan 2007 11:48:51 PM UTC, original submission:  

This patch adds callbacks to src/data/dictionary to notify us when the filter variable and/or split variables have changed.  It adds
code to the gui to update the status bar accordingly.

Testing, revealed some callback related bugs (temporary transformations kept crashing and other wierd things).  So this patch also has refactored some code, in an attempt to ensure that callbacks do get invoked when appropriate.

I'm posting this patch in case I've done anything evil in src/data/dictionary.c or src/data/procedure.c

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11687:  callbacks.patch added by jmd (16KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-01-07 jmd StatusWorks For Me Done
        Assigned tojmd None
        Open/ClosedOpen Closed
    2007-01-07 blp StatusReady For Test/Review Works For Me
        Assigned toblp jmd
    2007-01-06 jmd Attached File- Added callbacks.patch, #11687

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code