patchPSPP - Patches: patch #5641, Provide friendlier access to...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5641: Provide friendlier access to active file

Submitter:  Ben Pfaff <blp>
Submitted:  Sun 17 Dec 2006 06:34:43 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Tue 19 Dec 2006 02:22:29 PM UTC, comment #2: 

I checked this in.

Ben Pfaff <blp>
Group administrator
Mon 18 Dec 2006 09:11:46 PM UTC, comment #1: 

Seems fine to me.

John Darrington <jmd>
Group administrator
Sun 17 Dec 2006 06:34:43 AM UTC, original submission:  

In the past I've heard from both Jason and John that the interface to the active file, via procedure() and related functions, is a pain.  I've always agreed but I've always thought it would be impractical to offer a better interface, that is, one where you can just call a function to read a case.

I was wrong.  This patch allows just that, and adapts some code to use the new interface.  It also reimplements the existing procedure() interface in terms of the new one, so that existing code can be gradually converted as convenience allows.

I have ideas about how this can be made even better, but I'd like to get this in first, and then layer those on top.  What do you think?

This patch also deletes MATRIX DATA, because I didn't feel like converting it to the new case_source_class interface.  It didn't really work anyway.  We can add it back later, based on the old code if desirable, and actually make it work this time.


 doc/data-io.texi                   |  103 -
 src/data/ChangeLog                 |   34
 src/data/case-source.c             |   12
 src/data/case-source.h             |   23
 src/data/procedure.c               |  248 ++--
 src/data/procedure.h               |    6
 src/data/storage-stream.c          |  135 +-
 src/data/transformations.c         |   10
 src/data/transformations.h         |    6
 src/language/ChangeLog             |    8
 src/language/command.def           |    2
 src/language/data-io/ChangeLog     |   33
 src/language/data-io/automake.mk   |    1
 src/language/data-io/data-list.c   |   35
 src/language/data-io/get.c         |  435 +++-----
 src/language/data-io/inpt-pgm.c    |   76 -
 src/language/data-io/matrix-data.c | 1990 -------------------------------------
 src/language/stats/ChangeLog       |   21
 src/language/stats/aggregate.c     |   64 -
 src/language/stats/autorecode.c    |   57 -
 src/language/stats/flip.c          |   76 -
 21 files changed, 675 insertions(+), 2700 deletions(-)


Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11544:  invert-proc.patch added by blp (121KiB - text/x-patch - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-12-19 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2006-12-18 jmd Assigned tojmd None
    2006-12-17 blp Attached File- Added invert-proc.patch, #11544

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code