patchPSPP - Patches: patch #5623, Remove lexer's eof state

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5623: Remove lexer's eof state

Submitter:  John Darrington <jmd>
Submitted:  Fri 08 Dec 2006 10:36:17 PM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 10 Dec 2006 02:58:51 AM UTC, comment #1: 

Looks OK to me.  Feel free to commit it when you're ready.

Ben Pfaff <blp>
Group administrator
Fri 08 Dec 2006 10:36:17 PM UTC, original submission:  

This change is necessary for the GUI.  Currently, if the lexer reaches end of file, it can never get out of that state.  This is fine in the CLI, but in the GUI code can get pasted into the syntax window after the lexer has decided that there's no more input.

This changed removes the eof variable.  Instead, it sets prog to NULL.  When testing for eof, it tests prog, and calls lex_get_line.

It passes make check, but maybe there are some issues I've overlooked.

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11488:  lex.patch added by jmd (13KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-12-10 jmd StatusWorks For Me Done
        Assigned tojmd None
        Open/ClosedOpen Closed
    2006-12-10 blp StatusReady For Test/Review Works For Me
        Assigned toblp jmd
    2006-12-08 jmd Attached File- Added lex.patch, #11488

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code