patchPSPP - Patches: patch #5614, Make "struct variable"...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5614: Make "struct variable" opaque: phase 1

Submitter:  Ben Pfaff <blp>
Submitted:  Tue 05 Dec 2006 06:38:26 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  blp
Open/Closed:  Closed

Tue 05 Dec 2006 03:18:47 PM UTC, comment #2: 


>I can't see any problems here. I haven't examined it in detail,
>but like you say, it's pretty simple.


OK, I checked it in.

>Why are the changes to the tests necessary?


I noticed that some tables had titles of the form "<varname>: <varlabel>".  When the variables had no label, this came out as "<varname>: ", which doesn't look good.  So I change it to be just "<var-label-or-name>" using var_to_string().

Ben Pfaff <blp>
Group administrator
Tue 05 Dec 2006 11:24:50 AM UTC, comment #1: 

I can't see any problems here.  I haven't examined it in detail, but like you say, it's pretty simple.

Why are the changes to the tests necessary?


John Darrington <jmd>
Group administrator
Tue 05 Dec 2006 06:38:26 AM UTC, original submission:  

Here's the first step in making struct variable opaque.  In this step I do the boring mechanical work of replacing most struct variable member accesses by use of setter and getter functions.

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11453:  opaque-var.patch added by blp (199KiB - text/x-patch - opaque struct variable patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-12-05 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2006-12-05 jmd Assigned tojmd blp
    2006-12-05 blp Attached File- Added opaque-var.patch, #11453

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code