PSPP - Patches: patch #5614, Make "struct variable"...
You are not allowed to post comments on this tracker with your current authentication level.
patch #5614: Make "struct variable" opaque: phase 1
Submitter: | Ben Pfaff <blp> | ||
Submitted: | Tue 05 Dec 2006 06:38:26 AM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | blp |
Open/Closed: | Closed |
Tue 05 Dec 2006 03:18:47 PM UTC, comment #2: |
Ben Pfaff <blp> |
Tue 05 Dec 2006 11:24:50 AM UTC, comment #1: I can't see any problems here. I haven't examined it in detail, but like you say, it's pretty simple.
|
John Darrington <jmd> |
Tue 05 Dec 2006 06:38:26 AM UTC, original submission:
Here's the first step in making struct variable opaque. In this step I do the boring mechanical work of replacing most struct variable member accesses by use of setter and getter functions. |
Ben Pfaff <blp> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2006-12-05 | blp | Status | Ready For Test/Review | Done | |
Open/Closed | Open | Closed | |||
2006-12-05 | jmd | Assigned to | jmd | blp | |
2006-12-05 | blp | Attached File | - | Added opaque-var.patch, #11453 |
Powered by Savane 3.13-f8d8.
Corresponding source code
OK, I checked it in.
I noticed that some tables had titles of the form "<varname>: <varlabel>". When the variables had no label, this came out as "<varname>: ", which doesn't look good. So I change it to be just "<var-label-or-name>" using var_to_string().