patchPSPP - Patches: patch #5562, line-buffer / getl_ reorganisation

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5562: line-buffer / getl_ reorganisation

Submitter:  John Darrington <jmd>
Submitted:  Fri 17 Nov 2006 03:29:59 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Wed 29 Nov 2006 11:52:12 AM UTC, comment #4: 

Done.

I noticed a bug in the DO REPEAT feature, but it seems to predate anything I've done.  So I've posted a bug report and not attempted to fix it.

John Darrington <jmd>
Group administrator
Wed 29 Nov 2006 05:37:31 AM UTC, comment #3: 

I'm pretty happy with this.  Nit-picking follows:

In prompt.[ch], could the functions be renamed to put "prompt" at the
beginning?  e.g. get_prompt_style -> prompt_get_style and so on.  This
would make it clear at a glance that they come from a module named
"prompt".

I think that the function source is only used in DO REPEAT.  I wonder
whether it should be merged in with it.  It seems like the
function_source is a really thin wrapper around getl_interface now; it
was less apparently "thin" before, because it was the exposed
interface.  If you don't like merging it, could the source file be
named something less generic?  Maybe "function-source.c"?

Ben Pfaff <blp>
Group administrator
Sun 26 Nov 2006 05:14:30 AM UTC, comment #2: 

Here's another patch against the current HEAD.

It makes the object into a pure virtual interface.  As a result, many of the new files introduced in the previous patch are now redundant and have been removed.

I've renamed things into reasonably consistent schemas.  line-buffer.[ch] I've renamed to getl.[ch], but it bears little resemblence to the file that we once had with that name.


John Darrington <jmd>
Group administrator
Sat 18 Nov 2006 05:20:36 AM UTC, comment #1: 

I'm OK with this in principle given that (as you say) you recognize that the naming can be improved.  I'm too tired at the moment to try to invent good ones right now.

>I'm wondering if it's worth further abstracting the notion of a
>"source location", so that it can be applied to "sources" which
>don't have "lines" (eg clicks on a gui menu) ....


One thing I want to improve in our error reporting is to do something like GCC does where it explains the series of files that were included to arrive at the current line.  I don't expect you to add that in this patch, but I think that it's a good idea...

Ben Pfaff <blp>
Group administrator
Fri 17 Nov 2006 03:29:59 AM UTC, original submission:  

This patch :

  1. Finally disentangles the sourcefile/line number reporting from      the internals  of INCLUDE and DO REPEAT commands.
  2. Opens the way for the gui to run syntax files.


No doubt some things need to be renamed.  I'm open to suggestions.

At some stage I think it may be necessary to further encapsulate line-buffer, so that multiple ones can co-exist, but that can wait.

I'm wondering if it's worth further abstracting the notion of a "source location", so that it can be applied to "sources" which don't have "lines" (eg clicks on a gui menu) ....

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11356:  lb2.patch added by jmd (274KiB - text/x-patch)
file #11286:  lb.patch added by jmd (75KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 12 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-11-29 jmd StatusWorks For Me Done
        Assigned tojmd None
        Open/ClosedOpen Closed
    2006-11-29 blp StatusReady For Test/Review Works For Me
        Assigned toblp jmd
    2006-11-26 jmd StatusWorks For Me Ready For Test/Review
        Assigned tojmd blp
        Attached File- Added lb2.patch, #11356
    2006-11-25 blp StatusReady For Test/Review Works For Me
        Assigned toblp jmd
    2006-11-17 jmd StatusNone Ready For Test/Review
    2006-11-17 jmd Attached File- Added lb.patch, #11286

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code