patchidutils - Patches: patch #5165, Possible fix for when HAVE_LINK...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5165: Possible fix for when HAVE_LINK EQU 0

Submitter:  Claudio Fontana <sick_soul>
Submitted:  Fri 09 Jun 2006 07:33:07 PM UTC
   
 
Category:  None Priority:  3 - Low
Status:  Done Privacy:  Public
Assigned to:  sick_soul Open/Closed:  Closed

Sun 08 Oct 2006 03:21:44 PM UTC, comment #1: 

I assume it is ok,
closing item since it's already in CVS.




Claudio Fontana <sick_soul>
Fri 09 Jun 2006 07:33:07 PM UTC, original submission:  

If we do not HAVE_LINK, we end up with an unresolved function at link time with current (and historic) code.

This small change seems to make sense, but could you take a look at it?

CLaudio

--- walker.c    27 Dec 2005 04:24:57 -0000      1.13
+++ walker.c    9 Jun 2006 19:24:08 -0000
@@ -185,7 +185,13 @@
   flink->fl_flags = (old_flags & ~(FL_TYPE_MASK|FL_SYM_LINK)) | new_flags;
   if (FL_IS_DIR (new_flags))
     {
-      struct file_link *alias_link = find_alias_link (flink, &st);
+
+      struct file_link *alias_link;
+#if HAVE_LINK
+      alias_link = find_alias_link (flink, &st);
+#else
+      alias_link = 0;
+#endif /* HAVE_LINK */

       if (alias_link)
        {

Claudio Fontana <sick_soul>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10150:  walker.c.HAVE_LINK.udiff added by sick_soul (473B - application/octet-stream - fix for unresolved symbol when not HAVE_LINK)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-10-08 sick_soul StatusReady For Test Done
    Assigned toNone sick_soul
    Open/ClosedOpen Closed
2006-06-09 sick_soul Attached File- Added walker.c.HAVE_LINK.udiff, #10150
    Carbon-Copy- Added meyering

Back to the top

Powered by Savane 3.13-758e.
Corresponding source code