patchgrep - Patches: patch #3832, fix savedir issue for gnulib import

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3832: fix savedir issue for gnulib import

Submitter:  Claudio Fontana <sick_soul>
Submitted:  Wed 16 Mar 2005 01:14:42 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Jump to the original submission

Wed 22 Aug 2012 05:44:36 PM UTC, comment #6: 

Since grep now does use fts, can this patch be closed?

Reuben Thomas <rrt>
Mon 08 Mar 2010 04:57:22 PM UTC, comment #5: 

For now, we decided to avoid using gnulib's savedir.  The code will be switched to use fts someday.

Would you like to give it a shot?

Paolo Bonzini <bonzini>
Mon 21 Mar 2005 08:56:54 AM UTC, comment #4: 

I trusted the current code too much.
The more portable code is in the .2.patch then.




Claudio Fontana <sick_soul>
Mon 21 Mar 2005 06:37:40 AM UTC, comment #3: 

You were better off omitting the size parameter, and staying
compatible with gnulib.  That is because POSIX says that the value
of st_size is undefined for directories, and we've encountered
hosts where st_size is effectively garbage.  If you try to invoke
malloc with a garbage argument, you're likely to allocate wayyyy
too much storage and break your program one way or another.

So I would stick with the gnulib approach here.

Paul Eggert <eggert>
Group Member
Sun 20 Mar 2005 03:28:58 PM UTC, comment #2: 

reverted to include the size parameter again, because it makes a lot of sense, and effectively use it instead of NAME_SIZE_DEFAULT.

Claudio Fontana <sick_soul>
Sun 20 Mar 2005 10:36:16 AM UTC, comment #1: 

patch modified to eliminate the size parameter (the newest savedir() from gnulib does not need it anymore).


Claudio Fontana <sick_soul>
Wed 16 Mar 2005 01:14:42 AM UTC, original submission:  

This patch addresses a problem with current lib/savedir.c, where the changes to savedir prototype and functionality from gnulib savedir would be overwritten by a gnulib import, breaking grep.

New files: src/savedir_exclude.c|h , built adapting the newest savedir() from gnulib with grep prototype and functionality.

Changes:
src/grep.c : call savedir_exclude instead of savedir
src/Makefile.am : add new files to build process

Apply from srcdir using patch -p1


Claudio Fontana <sick_soul>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8590:  fix_savedir_exclude.p1.3.patch added by sick_soul (8KiB - text/x-patch - reverted to include name_size parameter, and effectively use it instead of NAME_SIZE_DEFAULT)
file #8588:  fix_savedir_exclude.p1.2.patch added by sick_soul (8KiB - text/x-patch - better version of the patch that removes unneeded parameter)
file #8582:  fix_savedir_exclude.p1.patch added by sick_soul (8KiB - text/x-patch - p1 patch that fixes the savedir + gnulib import issue)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by meyering (Updated the item)
  • -email is unavailable- added by rrt (Posted a comment)
  • -email is unavailable- added by bonzini (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-10 meyering StatusPostponed Done
        Open/ClosedOpen Closed
    2010-03-08 bonzini StatusNone Postponed
    2005-03-20 sick_soul Attached File- Added fix_savedir_exclude.p1.3.patch, #4366
    2005-03-20 sick_soul Attached File- Added fix_savedir_exclude.p1.2.patch, #4364
    2005-03-16 sick_soul Attached File- Added fix_savedir_exclude.p1.patch, #4354

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code