patchgrep - Patches: patch #3801, Red Hat's "color" patch

 
 

You are not allowed to post comments on this tracker with your current authentification level.

patch #3801: Red Hat's "color" patch

Submitted by:  Charles Levert <charles_levert>
Submitted on:  Tue 08 Mar 2005 11:58:41 AM UTC  
 
Category: NonePriority: 5 - Normal
Status: Wont DoPrivacy: Public
Assigned to: NoneOpen/Closed: Closed

Mon 13 Jun 2005 08:26:49 PM UTC, comment #4:

Obsoleted by bug #11022 is what I meant.

Julian Foad <julianfoad>
Mon 13 Jun 2005 08:23:46 PM UTC, comment #3:

Obsoleted by patch #11022.

Julian Foad <julianfoad>
Thu 28 Apr 2005 12:19:50 PM UTC, comment #2:

This patch #3801 is completely obsoleted by patch #3644. The shortcoming of this approach are also discussed under bug #11022, which includes its own attached patch which can also be considered obsolete and should not be applied to CVS.

Charles Levert <charles_levert>
Thu 28 Apr 2005 11:44:39 AM UTC, comment #1:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=138913

Summary: if grep's output causes the terminal to scroll while grep is printing text with a different background colour, the terminal fills the new line with that background colour and then grep may not fill the whole line with new text, so the end of the line remains the wrong colour.

This patch attempts to print a "clear to end of line" control sequence after the output, which gives the desired effect in this case. I'm not completely sure that this is the right thing to do anyway, though it may be and I can't think of anything better.

However, the current version of the patch appears to miss the "only_matching" and "match_icase" cases.

Julian Foad <julianfoad>
Tue 08 Mar 2005 11:58:41 AM UTC, original submission:

This item is created to document in Savannah the existence of the following patch from Red Hat/Fedora:
<http://cvs.fedora.redhat.com/viewcvs/devel/grep/>
:pserver:anonymous@cvs.fedora.redhat.com:/cvs/dist
grep-2.5.1-color.patch

Here is the relevant log content:
* Tue Nov 16 2004 Tim Waugh <twaugh@redhat.com> 2.5.1-39
- Fixed last patch.
* Tue Nov 16 2004 Tim Waugh <twaugh@redhat.com> 2.5.1-38
- Applied patch from Karsten Hopp to fix background colour problems with --color output (bug #138913).

Charles Levert <charles_levert>

 

No files currently attached

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 7 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 13 Jun 2005 10:09:57 PM UTCjulianfoadDependenciesRemoved dependancy to patch #3644=>-
Mon 13 Jun 2005 08:23:46 PM UTCjulianfoadStatusNone=>Wont Do
  Open/ClosedOpen=>Closed
Thu 28 Apr 2005 04:19:40 PM UTCcharles_levertSummaryRed Hat\'s \=>Red Hat's "color" patch
  Dependencies-=>Depends on bugs #11022
Thu 28 Apr 2005 04:18:18 PM UTCcharles_levertSummaryRed Hat's "color" patch=>Red Hat\'s \
  Dependencies-=>Depends on patch #3644

Back to the top


Powered by Savane 3.1-cleanup