patchGNU Autoconf Archive - Patches: patch #10191, Fix R package version comparison

 
 

patch #10191: Fix R package version comparison

Submitter:  Ricardo Wurmus <rekado>
Submitted:  Tue 29 Mar 2022 12:55:27 PM UTC
   
 
Priority:  5 - Normal Status:  Done
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 07 Sep 2022 06:02:30 AM UTC, comment #2: 

Applied in 4755d4939973cb625f67db44f4838127141d1016 and 41e75848c61db8b2786c7c114d847d5c217ded09. Thank you very much for the submission.

Peter Simons <simons>
Group administrator
Sat 28 May 2022 10:38:36 PM UTC, comment #1: 

Friendly ping.  I'd be happy if you could let me know if there is something I should change about this patch.

Ricardo Wurmus <rekado>
Tue 29 Mar 2022 12:55:27 PM UTC, original submission:  

The R package version comparison is broken.  When looking for a package with a version higher than 1.3.3 and 1.20.0 is found, the test fails.

This patch fixes this by using R's `compareVersion` instead of comparing strings.

The second patch uses `packageDescription` instead of `system.file`, because it's simpler and avoids false positives.

Ricardo Wurmus <rekado>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by rekado (Submitted the item)
  •  

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-09-07 simons StatusNone Done
        Open/ClosedOpen Closed
    2022-03-29 rekado Attached File- Added 0001-AX_R_PACKAGE-Fix-version-comparison.patch, #53018
        Attached File- Added 0002-AX_R_PACKAGE-Use-packageDescription.patch, #53019

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code