bugGNU Wget - Bugs: bug #40908, Wget checks URL name for length...

 
 

bug #40908: Wget checks URL name for length when output filename is provided

Submitted by:  Darshit Shah <darnir>
Submitted on:  Mon 16 Dec 2013 11:04:15 AM UTC  
 
Category: User InterfaceSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: Giuseppe Scrivano <gscrivano>
Originator Name: Darshit ShahOpen/Closed: Closed
Release: trunkOperating System: GNU/Linux
Reproducibility: Every TimeFixed Release: None
Planned Release: NoneRegression: No
Work Required: NonePatch Included: No

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 10 Jan 2014 12:40:03 PM UTC, comment #1:

patch pushed upstream.

Giuseppe Scrivano <gscrivano>
Project AdministratorIn charge of this item.
Mon 16 Dec 2013 11:04:15 AM UTC, original submission:

Even when Wget is invoked with -O, url.c only checks the input URL's length and attempts to shorten it for the output filename. Wget should however be checking the output filename provided with the -O switch. The above can be seen in the following output:

$ wget -c -O 'SomeVideo.mp4' 'http://r1---sn-huoa-cvhe.googlevideo.com/videoplayback?sparams=id%2Cip%2Cipbits%2Citag%2Cratebypass%2Csource%2Cupn%2Cexpire&source=youtube&mv=m&ipbits=0&ms=au&mt=1387162415&sver=3&id=3941ef8b48b84344&expire=1387182704&key=yt5&ip=182.56.47.187&upn=IT4CqAaRT9o&fexp=933406%2C937411%2C906440%2C914055%2C916625%2C929305%2C901442%2C902545%2C909717%2C932295%2C936912%2C936910%2C923305%2C936913%2C907231%2C907240&ratebypass=yes&itag=18&signature=BDEC434201971418FBD714DDA864557D6069A246.39FE0240BC2FB8A6A451F9575B2970F731CBABA5'

The name is too long, 479 chars total.
Trying to shorten...
New name is videoplayback?sparams=id%2Cip%2Cipbits%2Citag%2Cratebypass%2Csource%2Cupn%2Cexpire&source=youtube&mv=m&ipbits=0&ms=au&mt=1387162415&sver=3&id=3941ef8b48b84344&expire=1387182704&key=yt5&ip=182.56.47.187&upn=IT4CqAaRT9o&fexp=933406%2C9374.
--2013-12-16 13:55:31-- http://r1---sn-huoa-cvhe.googlevideo.com/videoplayback?sparams=id%2Cip%2Cipbits%2Citag%2Cratebypass%2Csource%2Cupn%2Cexpire&source=youtube&mv=m&ipbits=0&ms=au&mt=1387162415&sver=3&id=3941ef8b48b84344&expire=1387182704&key=yt5&ip=182.56.47.187&upn=IT4CqAaRT9o&fexp=933406%2C937411%2C906440%2C914055%2C916625%2C929305%2C901442%2C902545%2C909717%2C932295%2C936912%2C936910%2C923305%2C936913%2C907231%2C907240&ratebypass=yes&itag=18&signature=BDEC434201971418FBD714DDA864557D6069A246.39FE0240BC2FB8A6A451F9575B2970F731CBABA5
Resolving r1---sn-huoa-cvhe.googlevideo.com (r1---sn-huoa-cvhe.googlevideo.com)... 203.94.209.140
Connecting to r1---sn-huoa-cvhe.googlevideo.com (r1---sn-huoa-cvhe.googlevideo.com)|203.94.209.140|:80... ^C

Darshit Shah <darnir>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30068:  bugfix_40908.patch added by hauk142 (943B - text/x-patch - This patch fixes this bug, please review.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gscrivano (Posted a comment)
  • -unavailable- added by hauk142 (Updated the item)
  • -unavailable- added by darnir (Submitted the item)
  • -unavailable- added by darnir
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 10 Jan 2014 12:40:03 PM UTCgscrivanoOpen/ClosedOpen=>Closed
    Fri 10 Jan 2014 12:40:02 PM UTCgscrivanoStatusNone=>Fixed
      Assigned toNone=>gscrivano
    Sun 22 Dec 2013 10:39:25 PM UTChauk142Attached File-=>Added bugfix_40908.patch, #30068
    Mon 16 Dec 2013 11:04:15 AM UTCdarnirCarbon-Copy-=>Added darnir

    Back to the top


    Powered by Savane 3.1-cleanup