bugPSPP - Bugs: bug #40380, Crash when opening files from...

 
 

bug #40380: Crash when opening files from directory with no write permission

Submitted by:  John Darrington <jmd>
Submitted on:  Sat 26 Oct 2013 07:55:46 AM UTC  
 
Category: Output DriverSeverity: 5 - Average
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: None
Effort: 0.00

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 01 Nov 2013 09:24:59 AM UTC, comment #4:

I fixed this.

John Darrington <jmd>
Project Administrator
Sun 27 Oct 2013 08:37:50 PM UTC, comment #3:

It might be obvious (not sure) but the key part of the valgrind output in comment #2 is that output_submit__() is called recursively in the backtrace following "Address 0x5e3e06c is 4 bytes inside a block of size 20 free'd"

Ben Pfaff <blp>
Project Administrator
Sun 27 Oct 2013 08:36:29 PM UTC, comment #2:

Valgrind shows that the underlying problem is that output drivers are being entered recursively:

If I revert commit fce028c380d4 (Use the msg function to report errors wherever possible.) then that fixes the problem, so this is a regression. It seems that its approach to reentrancy avoidance is incomplete. I like that commit's goal, so I'd prefer to fix it up rather than revert it.

Ben Pfaff <blp>
Project Administrator
Sat 26 Oct 2013 07:46:57 PM UTC, comment #1:

Backtrace:

Ben Pfaff <blp>
Project Administrator
Sat 26 Oct 2013 07:55:46 AM UTC, original submission:

1. Change to a directory for which you have no write permission (eg: cd /usr/bin)

2. Start psppire

3. From the "Recently Used Data" menu select a file to open.

4. I see :

error opening output file `pspp.jnl': Permission denied
Segmentation fault

Strangely, the segfault seems only to come when opening from the recently used filelist.

John Darrington <jmd>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by blp (Posted a comment)
  • -unavailable- added by jmd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 01 Nov 2013 09:24:59 AM UTCjmdStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Sat 26 Oct 2013 07:46:57 PM UTCblpStatusNone=>Confirmed

    Back to the top


    Powered by Savane 3.1-cleanup