bugGNU Octave - Bugs: bug #39410, findobj() lacks precedence for...

 
 

bug #39410: findobj() lacks precedence for logical expressions

Submitted by:  Ben Abbott <bpabbott>
Submitted on:  Fri 05 Jul 2013 11:08:24 AM UTC  
 
Category: Octave FunctionSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Inaccurate Result
Status: FixedAssigned to: Ben Abbott <bpabbott>
Originator Name: Ben AbbottOpen/Closed: Closed
Release: devOperating System: Any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 20 Jul 2013 02:23:35 PM UTC, comment #4:

As there are no reports of regressions or problems, I'm changing the status to "fixed" and closing the report.

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Fri 05 Jul 2013 09:15:24 PM UTC, comment #3:

I pushed a changeset. The findobj() m-file may benefit a lot by conversion to c++

http://hg.savannah.gnu.org/hgweb/octave/rev/562301c71bd3

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Fri 05 Jul 2013 11:19:54 AM UTC, comment #2:

My original comment got truncated.

Is it preferable to implement findobj() in c++ and use the parser to handle the
precedence?

If not, I think it is possible to do something clumsy in an m-file (we only need to support the logical operations "-and", "-or", "-xor", and "-not")

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Fri 05 Jul 2013 11:15:49 AM UTC, comment #1:

I added the test below to findobj()

http://hg.savannah.gnu.org/hgweb/octave/rev/434a0b29ab12

Ben Abbott <bpabbott>
Project MemberIn charge of this item.
Fri 05 Jul 2013 11:08:24 AM UTC, original submission:

The logical operators supported by findobj() should parse as if they were part of a logical equation. For example, the current implementation does not give precedence of "-and" over "-or".

Ben Abbott <bpabbott>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bpabbott (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 20 Jul 2013 02:23:35 PM UTCbpabbottStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 05 Jul 2013 09:15:24 PM UTCbpabbottStatusNone=>Ready For Test
      Assigned toNone=>bpabbott

    Back to the top


    Powered by Savane 3.1-cleanup