bugPSPP - Bugs: bug #39366, Regression /save = is wrong when...

 
 

bug #39366: Regression /save = is wrong when splits are active.

Submitted by:  John Darrington <jmd>
Submitted on:  Sat 29 Jun 2013 06:12:18 AM UTC  
 
Category: Numerical ErrorsSeverity: 7 - Major
Status: FixedAssigned to: None
Open/Closed: ClosedRelease: Before 0.8.0
Effort: 0.00

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 17 Jul 2013 04:29:29 PM UTC, comment #6:

OK. Thanks for the review. I pushed a change addressing all these issues.

Closing this item.

John Darrington <jmd>
Project Administrator
Wed 17 Jul 2013 06:04:53 AM UTC, comment #5:

I spent a little time reading the code. I noticed the following:

I think that if the DEPENDENT subcommand is given twice (a user error), then the variables specified the first time will be silently leaked.

cmd_regression() has two local variables named 'i'.

I don't understand why "struct workspace" has a member 'psw' that is a dynamically allocated array, because it looks like each element of the array is used only during processing a single split file group. That is, I think that 'psw' could be just a singleton, instead of an array.

I think that fill_all_vars() is wrong: if an absent var follows a not-absent var, then vars[] will be filled with a gap and there will be a write into unallocated memory.

Ben Pfaff <blp>
Project Administrator
Tue 09 Jul 2013 04:08:00 PM UTC, comment #4:

I suggest that you look at regression.c as a whole:

Can you spot any uses of REGRESSION which might lead to crashes,
uninitialised memory reads or other nasties?

Then perhaps look at the
diff between 1ad157fcdfc62c0751b03c2781e3c2c0bd193c60 and HEAD.

Is there anything you can spot which might make the code less reliable?

John Darrington <jmd>
Project Administrator
Tue 09 Jul 2013 06:09:19 AM UTC, comment #3:

> regression.c could use a review before we finally call this closed.


I'm happy to do that. What kind of review would be most helpful?

Ben Pfaff <blp>
Project Administrator
Wed 03 Jul 2013 05:06:38 PM UTC, comment #2:

I pushed what I hope is the final fix for these regression problems.

I have added a couple of new tests to make sure they stay fixed.

All the memory leaks have been plugged.

regression.c could use a review before we finally call this closed.

John Darrington <jmd>
Project Administrator
Tue 02 Jul 2013 08:28:19 PM UTC, comment #1:

I'm working on this. I hope to have a fix within the next few days.

John Darrington <jmd>
Project Administrator
Sat 29 Jun 2013 06:12:18 AM UTC, original submission:

The regression command is not behaving correctly when SPLIT FILE is active and the /SAVE subcommand is used.

The attached file demonstrates the problem.

We need to fix this, and add some more tests for the regression command.

John Darrington <jmd>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #28449:  reg.sps added by jmd (877B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by blp (Posted a comment)
  • -unavailable- added by jmd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 17 Jul 2013 04:29:29 PM UTCjmdStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Tue 02 Jul 2013 08:28:19 PM UTCjmdStatusNone=>In Progress
    Sat 29 Jun 2013 06:13:10 AM UTCjmdReleaseNone=>Before 0.8.0
    Sat 29 Jun 2013 06:12:18 AM UTCjmdAttached File-=>Added reg.sps, #28449

    Back to the top


    Powered by Savane 3.1-cleanup