bugCompact Disc Input and Control Library - Bugs: bug #39353, filename concatenation defect

 
 

bug #39353: filename concatenation defect

Submitted by:  Leo Baschy <infrastrug>
Submitted on:  Fri 28 Jun 2013 12:50:39 AM UTC  
 
Category: NoneSeverity: 1 - Low
Item Group: NoneStatus: Postponed
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 16 Sep 2013 12:46:35 AM UTC, comment #4:

Agree.

Looked at it again, and think this is more a question of code readability, choice of variable names and/or comments.

This probably is not an actual defect.

Would be reasonable to close or lower priority.

Leo Baschy <infrastrug>
Mon 16 Sep 2013 12:20:04 AM UTC, comment #3:

This is low priority until an example of a failure can be shown.

Rocky Bernstein <rocky>
Project Administrator
Sun 15 Sep 2013 11:51:15 PM UTC, comment #2:

While I cannot pinpoint where this would have an effect, I am still suspicious of printing (into a string)

in find_lsn_recurse in iso9660_fs.c.

Relevant search for uses might be

Relevant search for similarly suspicious (not necessarily wrong) code might be

If no effects of this are known then maybe this doesn't need to be addressed now. This comment then is merely a hint for investigation in case of future problems.

Leo Baschy <infrastrug>
Sat 29 Jun 2013 05:30:41 PM UTC, comment #1:

I'll try to look at this when I get a chance. Thanks.

Rocky Bernstein <rocky>
Project Administrator
Fri 28 Jun 2013 12:50:39 AM UTC, original submission:

In git at lib/iso9660/iso9660_fs.c line 1407 I see

and that seems wrong.

Shouldn't that be

?

Leo Baschy <infrastrug>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by infrastrug (Submitted the item)
  • -unavailable- added by infrastrug
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 06 Oct 2013 04:10:19 PM UTCrockyStatusNone=>Postponed
    Mon 16 Sep 2013 12:20:03 AM UTCrockySeverity5 - Average=>1 - Low
    Fri 28 Jun 2013 12:50:39 AM UTCinfrastrugCarbon-Copy-=>Added infrastrug

    Back to the top


    Powered by Savane 3.1-cleanup