bugPSPP - Bugs: bug #38634, Data Load/Import needs to be...

 
 

bug #38634: Data Load/Import needs to be canonicalised and use the DATASET command.

Submitted by:  Mindaugas <embar>
Submitted on:  Sat 30 Mar 2013 12:57:14 PM UTC  
 
Category: Graphical User InterfaceSeverity: 3 - Ordinary
Status: NoneAssigned to: None
Open/Closed: OpenRelease: Before 1.0
Effort: 0.00

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 24 May 2013 03:24:43 PM UTC, comment #6:

I pushed these patches and retitle and reprioritise this bug.

John Darrington <jmd>
Project Administrator
Tue 21 May 2013 03:06:00 AM UTC, comment #5:

> That probably is the correct way - that's why I said this wasn't an ideal patch.


OK. I guess this is OK for now. I hope we can do better later.

Ben Pfaff <blp>
Project Administrator
Sat 18 May 2013 06:27:46 PM UTC, comment #4:

That probably is the correct way - that's why I said this wasn't an
ideal patch. But the correct solution is a little more complicated I think. The new dataset should only be created if the current dataset is non empty. Also I want to use common code were possible, for opening a .sav/,por file as with spreadsheet/text files.

John Darrington <jmd>
Project Administrator
Sat 18 May 2013 03:35:45 PM UTC, comment #3:

> I'm not too happy with the how this all works. But I think it is the best solution at the current time.


Can the text import dialog just generate DATASET DECLARE followed by DATASET ACTIVATE? I think that will have the effect of creating a new dataset, in a new window, and then allowing the import happen into the new dataset.

Ben Pfaff <blp>
Project Administrator
Sat 18 May 2013 03:13:53 PM UTC, comment #2:

Attached are two patches to collectively fix this problem.

I'm not too happy with the how this all works. But I think it is the best solution at the current time.

I'm posting them here for review, in case there is a major problem that I'm not seeing.

Test and review appreciated.

(file #28103, file #28104)

John Darrington <jmd>
Project Administrator
Sat 18 May 2013 01:29:00 PM UTC, comment #1:

I'm looking at how best to do this.

John Darrington <jmd>
Project Administrator
Sat 30 Mar 2013 12:57:14 PM UTC, original submission:

You work in PSPP 0.7.10 with two datasets,
and you are in second dataset.
Then you import data from text file.
Result – data in second dataset is lost – data is overwritten by new data, but dataset header is as old (second) dataset.

Mindaugas <embar>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by blp (Posted a comment)
  • -unavailable- added by jmd (Updated the item)
  • -unavailable- added by embar (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 24 May 2013 03:24:43 PM UTCjmdSeverity5 - Average=>3 - Ordinary
      StatusIn Progress=>None
      ReleaseBefore 0.8.0=>Before 1.0
      SummaryData import from Text file: data imported on top of current DataSet=>Data Load/Import needs to be canonicalised and use the DATASET command.
    Sat 18 May 2013 03:13:53 PM UTCjmdAttached File-=>Added 0001-Add-hint-paramater-to-Window-Load-method.patch, #28103
      Attached File-=>Added 0002-Open-imported-files-in-new-data-window-instead-of-ov.patch, #28104
    Sat 18 May 2013 01:29:00 PM UTCjmdStatusNone=>In Progress
    Sat 11 May 2013 06:34:21 AM UTCjmdReleaseNone=>Before 0.8.0

    Back to the top


    Powered by Savane 3.1-cleanup