bugmake - Bugs: bug #38626, make fails on windows with...

 
 

bug #38626: make fails on windows with antivirus software

Submitted by:  None
Submitted on:  Fri 29 Mar 2013 03:09:03 PM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Component Version: 3.81Operating System: MS Windows
Fixed Release: 4.0Triage Status: Verified

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 27 Apr 2013 05:12:32 PM UTC, comment #1:

Thanks for the report and the patch.

I think this bug is already solved in the git repository, albeit somewhat differently. Make now always increments the counter of the batch files before trying to create a new batch file. So if a file named make-NNNN-1.bat was already created in the current Make run (where NNNN is the PID of the Make process), the next batch file will be make-NNNN-2.bat; Make will not try reusing make-NNNN-1.bat, unless it tries all the 64K possible numbers, and starts reusing numbers it already used in the same run.

I needed this change for "make -j", where several batch files might be used simultaneously, and cannot possibly be deleted anyway, because some job is still using them.

So I'm closing this bug. Please try the git code and see if the problem still persists. If it does, please reopen this bug with details.

Eli Zaretskii <eliz>
Project Member
Fri 29 Mar 2013 03:09:03 PM UTC, original submission:

When make runs on windows using batch files to execute external programs, it doesn't handle correctly situation when file creation fails because delete is still pending.
This behaviour of CreateFile is mentioned here: http://msdn.microsoft.com/en-us/library/windows/desktop/aa363858(v=vs.85).aspx
Make then fails with 'permission denied' (increasing user confusion)

This problem is quite rare, usual resolution is to disable antivirus software or try again. It is masked a bit because make first tries temporary directory, then ./, both must fail.

Attached is patch that waits before giving up.
On my system it does sometimes take nearly one second to create new file (Process Monitor from Sysinternals and search for 'DELETE PENDING' result).

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27717:  make.patch added by None (812B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by eliz (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 27 Apr 2013 05:12:32 PM UTCelizStatusNone=>Fixed
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.0
      Triage StatusNone=>Verified
    Fri 29 Mar 2013 03:09:03 PM UTCNoneAttached File-=>Added make.patch, #27717

    Back to the top


    Powered by Savane 3.1-cleanup