bugGNU Screen - Bugs: bug #38567, [PATCH] exec: fix ':' for stdin

 
 

bug #38567: [PATCH] exec: fix ':' for stdin

Submitted by:  Stas Sergeev <stsp>
Submitted on:  Fri 22 Mar 2013 11:02:30 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Privacy: PublicAssigned to: None
Open/Closed: OpenRelease: None
Fixed Release: NonePlanned Release: None
Work Required: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 22 Mar 2013 11:02:30 AM UTC, original submission:

Hi.

I've found out that ':' for stdin in an exec pattern doesn't
work. The reason is that if '!' is used for stdin, then the
w_pty fd is just duped to the sub process, so that the p_pty
is bypassed. But with ':' there is a relay mechanism via the
p_pty. In order to match the behaviour of the bypassed pty,
the pty must be set to raw mode, which is what the attached
patch does.
Without the attached patch, if the relayed data does not contain
the '\n's, the sub-process will simply receive nothing at all, because
the pty is then line-buffered.

Does the patch look good?

Stas Sergeev <stsp>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27651:  0001-exec-fix-for-stdin.patch added by stsp (815B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by stsp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 22 Mar 2013 11:02:30 AM UTCstspAttached File-=>Added 0001-exec-fix-for-stdin.patch, #27651

    Back to the top


    Powered by Savane 3.1-cleanup